Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: pkg/polymer/lib/polymer.dart

Issue 225043004: Replace bootstrap logic with 'boot.js', use 'component/dart' mime-type and add (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/polymer/lib/polymer.dart
diff --git a/pkg/polymer/lib/polymer.dart b/pkg/polymer/lib/polymer.dart
index 72e70d76353777415808206391db64698001cee7..39f577947d3f3fd3bd10710d668f24fe24a076df 100644
--- a/pkg/polymer/lib/polymer.dart
+++ b/pkg/polymer/lib/polymer.dart
@@ -52,16 +52,14 @@ import 'dart:js' hide context;
// *** Important Note ***
// This import is automatically replaced when calling pub build by the
// mirrors_remover transformer. The transformer will remove any dependencies on
-// dart:mirrors in deployed polymer apps. This and the import to
-// mirror_loader.dart below should be updated in sync with changed in
-// lib/src/build/mirrors_remover.dart.
+// dart:mirrors in deployed polymer apps. This should be updated in sync with
+// changed in lib/src/build/mirrors_remover.dart.
//
-// Technically, if we have codegen for expressions we shouldn't need any
-// @MirrorsUsed (since this is for development only), but our test bots don't
-// run pub-build yet. Until then, polymer might be tested with mirror_loader
-// instead of the static_loader, however the actual code there is practically
-// dead ([initializers] will be set programatically with generated code
-// anyways), but the @MirrorsUsed helps reduce the load on our bots.
+// Technically this annotation is not needed now that we have codegen for
+// expressions, but our test bots don't run pub-build yet. Until then, tests
+// might (transitively) have an import to smoke.mirrors, even though the code is
+// completely dead. This @MirrorsUsed annotation helps reduce the load on our
+// bots.
@MirrorsUsed(metaTargets:
const [Reflectable, ObservableProperty, PublishedProperty, CustomTag,
ObserveProperty],
@@ -79,7 +77,6 @@ import 'package:smoke/smoke.dart' as smoke;
import 'package:template_binding/template_binding.dart';
import 'deserialize.dart' as deserialize;
-import 'src/mirror_loader.dart' as loader; // ** see important note above
export 'package:observe/observe.dart';
export 'package:observe/html.dart';

Powered by Google App Engine
This is Rietveld 408576698