Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 225043002: Move extension_icon_set.{h,cc} to //extensions (Closed)

Created:
6 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 8 months ago
Reviewers:
Jeffrey Yasskin, Finnur
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tfarina, dbeam+watch-ntp_chromium.org, oshima+watch_chromium.org, estade+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, pedrosimonetti+watch_chromium.org
Visibility:
Public.

Description

Move extension_icon_set.{h,cc} to //extensions This has no //chrome dependencies and can be moved. This change is purely mechanical. BUG=359836 TBR=atwilson@chromium.org (background) TBR=davemoor@chromium.org (c/b/chromeos) TBR=rohitrao@chromium.org (c/b/ui/cocoa/infobars) TBR=erg@chromium.org (c/b/ui/gtk) TBR=benwells@chromium.org (c/b/ui/views/apps, app_list) TBR=pkasting@chromium.org (c/b/ui/views/infobars) TBR=xiyuan@chromium.org (c/b/ui/webui) TBR=finnur@chromium.org (c/b/ui/webui/extensions) TBR=estade@chromium.org (ntp) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262253

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -167 lines) Patch
M chrome/browser/background/background_application_list_model.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/background/background_contents_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/merge_session_load_page.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/offline/offline_load_page.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/bookmark_app_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/convert_web_app_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/convert_web_app_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_action.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_action_icon_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_disabled_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_icon_image.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_icon_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_uninstall_dialog.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_util.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/image_loader_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/tab_helper.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/extension_app_item.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/app_result.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_tab.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/extension_infobar.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/app_list/start_page_handler.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_info_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/extension_action/action_info.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/extension_icon_set.h View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/common/extensions/extension_icon_set.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M chrome/common/extensions/extension_icon_set_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handler_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/icons_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/localized_error.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/extension_icon_set.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/extension_icon_set.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
Ken Rockot(use gerrit already)
Jeffrey, could you please take a look? It's a move + include updates.
6 years, 8 months ago (2014-04-04 00:44:01 UTC) #1
Finnur
c/b/ui/webui/extensions LGTM
6 years, 8 months ago (2014-04-04 11:13:55 UTC) #2
Ken Rockot(use gerrit already)
ping jyasskin@ as exensions OWNER
6 years, 8 months ago (2014-04-07 17:13:22 UTC) #3
Jeffrey Yasskin
LGTM. Sorry for the delay.
6 years, 8 months ago (2014-04-07 18:01:41 UTC) #4
Ken Rockot(use gerrit already)
Thanks, it's no problem
6 years, 8 months ago (2014-04-07 18:20:14 UTC) #5
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-07 18:20:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/225043002/20001
6 years, 8 months ago (2014-04-07 18:20:35 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-07 18:27:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 8 months ago (2014-04-07 18:27:39 UTC) #9
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-07 19:08:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/225043002/20001
6 years, 8 months ago (2014-04-07 19:09:00 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-07 19:14:38 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 8 months ago (2014-04-07 19:14:38 UTC) #13
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-07 20:57:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/225043002/20001
6 years, 8 months ago (2014-04-07 20:57:32 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-07 21:03:20 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 8 months ago (2014-04-07 21:03:21 UTC) #17
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-07 22:56:09 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/225043002/20001
6 years, 8 months ago (2014-04-07 22:56:23 UTC) #19
commit-bot: I haz the power
6 years, 8 months ago (2014-04-07 23:50:26 UTC) #20
Message was sent while issue was closed. 
Change committed as 262253

Powered by Google App Engine
This is Rietveld 408576698