Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: tests/PathTest.cpp

Issue 2250353004: move private test for sect_with_horizontal into unittests (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: clarify name of test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkLineClipper.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/PathTest.cpp
diff --git a/tests/PathTest.cpp b/tests/PathTest.cpp
index c76276080c959b2c49583f26d7526fa3f961d246..8a3022ccfe36d83697d80cbdabaaedbb75ad5f98 100644
--- a/tests/PathTest.cpp
+++ b/tests/PathTest.cpp
@@ -97,6 +97,20 @@ static void make_path_crbug364224_simplified(SkPath* path) {
path->close();
}
+static void test_sect_with_horizontal_needs_pinning() {
+ // Test that sect_with_horizontal in SkLineClipper.cpp needs to pin after computing the
+ // intersection.
+ SkPath path;
+ path.reset();
+ path.moveTo(-540000, -720000);
+ path.lineTo(-9.10000017e-05f, 9.99999996e-13f);
+ path.lineTo(1, 1);
+
+ // Without the pinning code in sect_with_horizontal(), this would assert in the lineclipper
+ SkPaint paint;
+ SkSurface::MakeRasterN32Premul(10, 10)->getCanvas()->drawPath(path, paint);
+}
+
static void test_path_crbug364224() {
SkPath path;
SkPaint paint;
@@ -4228,6 +4242,7 @@ DEF_TEST(PathContains, reporter) {
}
DEF_TEST(Paths, reporter) {
+ test_sect_with_horizontal_needs_pinning();
test_crbug_629455(reporter);
test_fuzz_crbug_627414(reporter);
test_path_crbug364224();
« no previous file with comments | « src/core/SkLineClipper.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698