presubmit_support.py - Issue 2250353003: Do not assume that all presubmit directories still exist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_support.py

Issue 2250353003: Do not assume that all presubmit directories still exist. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Don't reassign |files| Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_support.py

diff --git a/presubmit_support.py b/presubmit_support.py

index 2922b4e32938c873da53decfc4e646e9b8d73174..55b858f3582decb1b0180a7ed542c09ff7ec8fd4 100755

--- a/presubmit_support.py

+++ b/presubmit_support.py

@@ -1093,7 +1093,11 @@ def ListRelevantPresubmitFiles(files, root):

# Look for PRESUBMIT.py in all candidate directories.

results = []

for directory in sorted(list(candidates)):

- for f in os.listdir(directory):

+ try:

+ directory_files = os.listdir(directory)

+ except OSError:

+ directory_files = []

tandrii(chromium) 2016/08/17 09:39:13 continue it's shorter and faster.

Tobias Sargeant 2016/08/17 09:57:45 Thanks. It seems like it's best to just wrap the w

+ for f in directory_files:

p = os.path.join(directory, f)

if os.path.isfile(p) and re.match(

r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):

« no previous file with comments | « no previous file | no next file » | no next file with comments »