So apparently Chrome has an x86 iOS build...

So apparently Chrome has an x86 iOS build...

and for some reason we don't bother to build or link our SSE2 opts
there.  So don't go looking for them when SK_BUILD_FOR_IOS is set.

BUG=skia:
NOTREECHECKS=true
NOTRY=true

Committed: http://code.google.com/p/skia/source/detail?r=14147

[reed1, 2014-04-11 12:17:19]

happy to fix chrome, but does this mean we won't get this optimization on iOS?

What is the larger issue+fix going on around OPTS gypi problems?

[mtklein, 2014-04-11 12:26:45]

On 2014/04/11 12:17:19, reed1 wrote:
> happy to fix chrome, but does this mean we won't get this optimization on iOS?
> 
> What is the larger issue+fix going on around OPTS gypi problems?

We won't get this optimization on iOS simulator, or rather we are not getting
this optimization in the simulator now and this CL makes us stop looking for it.

We won't get it on real iOS devices because they, to date, don't have SSE2.

I'm not aware of a specific plan for opts, other than the general plan to get
all source lists into .gypis generally making the rolls easier and GN possible. 
opts is probably not near the top of the list of reasons to do this: it's fairly
rare that we're adding in a whole new entry point like this.  The next changes
to flesh out SSE2 xfermodes won't cause this same pain as the first. 
Historically this sort of change happens 1-3 times a year.

[djsollen, 2014-04-11 12:45:47]

lgtm

[reed1, 2014-04-11 12:46:04]

I'm stupid -- I didn't make this "its for the simulator" connection. my bad.

[mtklein, 2014-04-11 12:51:39]

On 2014/04/11 12:46:04, reed1 wrote:
> I'm stupid -- I didn't make this "its for the simulator" connection. my bad.

I too am drinking my first coffee right now. :)

[mtklein, 2014-04-11 12:51:43]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-04-11 12:51:49]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/225033003/1

[mtklein, 2014-04-11 12:52:26]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2014-04-11 12:52:32]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-04-11 12:52:39]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/225033003/1

[commit-bot: I haz the power, 2014-04-11 12:52:46]

Change committed as 14147