Add --issue flag to git cl status.

Add --issue flag to git cl status.

R=phajdan.jr@chromium.org, vadimsh@chromium.org
BUG=

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/3c972b9039766f02dd274a3620082b329d1f3ec3

[iannucci, 2016-08-17 19:36:50]

PTAL, this is a hack to allow a recipe to use `git cl` to obtain the status for
an issue without needing to modify the .git/config file in order to alter the
issue number.

[Vadim Sh., 2016-08-17 19:39:38]

lgtm if it works

https://codereview.chromium.org/2250323003/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2250323003/diff/20001/git_cl.py#newcode3294
git_cl.py:3294: if not options.field and options.issue is not None:
Is it None or 0? Option type is 'int', I forgot what's default value for such
options.

[tandrii(chromium), 2016-08-17 19:41:03]

tandrii@chromium.org changed reviewers:
+ tandrii@chromium.org

[tandrii(chromium), 2016-08-17 19:41:04]

https://codereview.chromium.org/2250323003/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2250323003/diff/20001/git_cl.py#newcode3298
git_cl.py:3298: cl = Changelist(auth_config=auth_config)
passing it here is also OK, so long as you know which codereview is being used,
and recipe roller is still hardcoding rietveld, so how about adding
force_code_review options as say in "CMDUpload"?

[iannucci, 2016-08-17 20:10:36]

On 2016/08/17 at 19:41:04, tandrii wrote:
> https://codereview.chromium.org/2250323003/diff/20001/git_cl.py
> File git_cl.py (right):
> 
> https://codereview.chromium.org/2250323003/diff/20001/git_cl.py#newcode3298
> git_cl.py:3298: cl = Changelist(auth_config=auth_config)
> passing it here is also OK, so long as you know which codereview is being
used, and recipe roller is still hardcoding rietveld, so how about adding
force_code_review options as say in "CMDUpload"?

PTAL again; added tests and I think I'm doing it more rightly now.

[iannucci, 2016-08-17 20:15:01]

On 2016/08/17 at 19:39:38, vadimsh wrote:
> lgtm if it works
> 
> https://codereview.chromium.org/2250323003/diff/20001/git_cl.py
> File git_cl.py (right):
> 
> https://codereview.chromium.org/2250323003/diff/20001/git_cl.py#newcode3294
> git_cl.py:3294: if not options.field and options.issue is not None:
> Is it None or 0? Option type is 'int', I forgot what's default value for such
options.

default is None, see test. *python* *waves hands*

[tandrii(chromium), 2016-08-17 20:16:32]

LGTM

and great tests coverage.

https://codereview.chromium.org/2250323003/diff/60001/tests/git_cl_test.py
File tests/git_cl_test.py (right):

https://codereview.chromium.org/2250323003/diff/60001/tests/git_cl_test.py#ne...
tests/git_cl_test.py:1540: git_cl.main(['status', '--issue', '1'])
add assert 0 :)

https://codereview.chromium.org/2250323003/diff/60001/tests/git_cl_test.py#ne...
tests/git_cl_test.py:1549: git_cl.main(['status', '--issue', '1', '--rietveld'])
ditto

https://codereview.chromium.org/2250323003/diff/60001/tests/git_cl_test.py#ne...
tests/git_cl_test.py:1797: 
delete

[tandrii(chromium), 2016-08-17 20:18:04]

On 2016/08/17 20:15:01, iannucci wrote:
> On 2016/08/17 at 19:39:38, vadimsh wrote:
> > lgtm if it works
> > 
> > https://codereview.chromium.org/2250323003/diff/20001/git_cl.py
> > File git_cl.py (right):
> > 
> > https://codereview.chromium.org/2250323003/diff/20001/git_cl.py#newcode3294
> > git_cl.py:3294: if not options.field and options.issue is not None:
> > Is it None or 0? Option type is 'int', I forgot what's default value for
such
> options.
> 
> default is None, see test. *python* *waves hands*
it's not really type, it's a function that is called when value is provided by
user. Hence, it's not called on default, which is quite handy when you set
('--input', default=sys.stdin, type=open)

[iannucci, 2016-08-17 20:20:36]

thx

https://codereview.chromium.org/2250323003/diff/60001/tests/git_cl_test.py
File tests/git_cl_test.py (right):

https://codereview.chromium.org/2250323003/diff/60001/tests/git_cl_test.py#ne...
tests/git_cl_test.py:1540: git_cl.main(['status', '--issue', '1'])
On 2016/08/17 at 20:16:32, tandrii(chromium) wrote:
> add assert 0 :)

done

https://codereview.chromium.org/2250323003/diff/60001/tests/git_cl_test.py#ne...
tests/git_cl_test.py:1549: git_cl.main(['status', '--issue', '1', '--rietveld'])
On 2016/08/17 at 20:16:32, tandrii(chromium) wrote:
> ditto

done

https://codereview.chromium.org/2250323003/diff/60001/tests/git_cl_test.py#ne...
tests/git_cl_test.py:1797: 
On 2016/08/17 at 20:16:32, tandrii(chromium) wrote:
> delete

done in later patchset :)

[iannucci, 2016-08-17 20:20:50]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2016-08-17 20:20:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
vadimsh@chromium.org, tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/2250323003/#ps120001
(title: "add more asserts")

[commit-bot: I haz the power, 2016-08-17 20:20:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 20:24:13]

Description was changed from

==========
Add --issue flag to git cl status.

R=phajdan.jr@chromium.org, vadimsh@chromium.org
BUG=
==========

to

==========
Add --issue flag to git cl status.

R=phajdan.jr@chromium.org, vadimsh@chromium.org
BUG=

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/3c972b9039766f...
==========

[commit-bot: I haz the power, 2016-08-17 20:24:14]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/3c972b9039766f...