Show Canadian dollars as"CAD $5.00" instead of "CAD CA$5.00".

Show Canadian dollars as"CAD $5.00" instead of "CAD CA$5.00".

BUG=638481
Committed: https://crrev.com/c07aecbf8485538922366e9ff0d3c2604879b27c
Cr-Commit-Position: refs/heads/master@{#413377}

[please use gerrit instead, 2016-08-17 05:48:41]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 05:49:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 06:20:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 06:20:29]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2016-08-17 16:53:12]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[please use gerrit instead, 2016-08-17 16:53:13]

dfalcantara, ptal.

Screenshot before:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=247263&inline=1

Screenshot after:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=247264&inline=1

[gone, 2016-08-17 17:05:26]

lgtm % random observations

https://codereview.chromium.org/2250313002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/CurrencyStringFormatter.java
(right):

https://codereview.chromium.org/2250313002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/CurrencyStringFormatter.java:74:
// If the prefix of the currency symobl matches the prefix of the the currency
code, remove
symobl

https://codereview.chromium.org/2250313002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/CurrencyStringFormatter.java:78:
for (int i = 0; i < currencySymbol.length(); i++) {
Seems like you could pull out that i >= currencyCode.length() check and just
check if currencySymbol.length() > currencyCode.length().

[please use gerrit instead, 2016-08-19 23:56:27]

Sending to cq.

https://codereview.chromium.org/2250313002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/CurrencyStringFormatter.java
(right):

https://codereview.chromium.org/2250313002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/CurrencyStringFormatter.java:74:
// If the prefix of the currency symobl matches the prefix of the the currency
code, remove
On 2016/08/17 17:05:25, dfalcantara wrote:
> symobl

Doen.

https://codereview.chromium.org/2250313002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/CurrencyStringFormatter.java:78:
for (int i = 0; i < currencySymbol.length(); i++) {
On 2016/08/17 17:05:25, dfalcantara wrote:
> Seems like you could pull out that i >= currencyCode.length() check and just
> check if currencySymbol.length() > currencyCode.length().

I think you mean that I should check "i < currencyCode.length()" on line 78.
That would result in symbol="" when currencyCode is "CAD" and currencySymbol is
"CAD$". Unlikely, I know, but better be safe than sorry. So I would rather leave
this code as it is written now.

[please use gerrit instead, 2016-08-19 23:56:32]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-08-19 23:56:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2250313002/#ps20001
(title: "Add integration test")

[commit-bot: I haz the power, 2016-08-19 23:57:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 03:56:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 03:56:42]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[please use gerrit instead, 2016-08-21 19:19:49]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-08-21 19:19:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2250313002/#ps40001
(title: "Use 'new Locale' constructor instead of 'Locale.forLanguageTag' static
method.")

[commit-bot: I haz the power, 2016-08-21 19:20:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-21 20:17:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-21 20:19:56]

Description was changed from

==========
Show Canadian dollars as"CAD $5.00" instead of "CAD CA$5.00".

BUG=638481
==========

to

==========
Show Canadian dollars as"CAD $5.00" instead of "CAD CA$5.00".

BUG=638481

Committed: https://crrev.com/c07aecbf8485538922366e9ff0d3c2604879b27c
Cr-Commit-Position: refs/heads/master@{#413377}
==========

[commit-bot: I haz the power, 2016-08-21 20:19:57]

Patchset 3 (id:??) landed as
https://crrev.com/c07aecbf8485538922366e9ff0d3c2604879b27c
Cr-Commit-Position: refs/heads/master@{#413377}