Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2250303004: Re-land "Make Buildbot masters send ts_mon metrics, and add standard HTTP server metrics. (Closed)

Created:
4 years, 4 months ago by dsansome
Modified:
4 years, 4 months ago
Reviewers:
Sergey Berezin
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Re-land "Make Buildbot masters send ts_mon metrics, and add standard HTTP server metrics. This is the 4th time I've landed this change and I have become exceedingly efficient at it. BUG=620610 TBR=sergeyberezin Committed: https://chromium.googlesource.com/chromium/tools/build/+/bdec453c0416ab58df8cbebad831345caa729553

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -5 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M masters/buildbot.tac View 1 chunk +24 lines, -1 line 0 comments Download
M scripts/master/master_utils.py View 2 chunks +3 lines, -1 line 0 comments Download
A scripts/master/monitoring_status_receiver.py View 1 chunk +41 lines, -0 lines 0 comments Download
M third_party/buildbot_8_4p1/buildbot/status/web/baseweb.py View 3 chunks +32 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dsansome
4 years, 4 months ago (2016-08-18 08:20:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250303004/1
4 years, 4 months ago (2016-08-18 08:21:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/bdec453c0416ab58df8cbebad831345caa729553
4 years, 4 months ago (2016-08-18 08:25:24 UTC) #7
Sergey Berezin
lgtm
4 years, 4 months ago (2016-08-18 17:08:57 UTC) #8
benzh
4 years, 4 months ago (2016-08-18 19:50:23 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2255333002/ by benzh@chromium.org.

The reason for reverting is: Broke falco-full-compile-paladin crbug.com/638980.

Powered by Google App Engine
This is Rietveld 408576698