[NaCl SDK] Earth demo modifications for gonacl PNaCl.

[NaCl SDK] Earth demo modifications for gonacl PNaCl.

NOTE: this change modifies only files that are manually tested, and therefore do not need to be try'd against Chromium or NaCl SDK.

BUG=none
R=eliben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217039

[binji, 2013-08-07 00:08:41]

Here are the changes I've made. You can find the built .pexe at
/home/binji/earth.pexe

[eliben, 2013-08-07 15:49:13]

LGTM, thanks

[eliben, 2013-08-07 19:46:46]

https://codereview.chromium.org/22503002/diff/10001/native_client_sdk/src/gon...
File native_client_sdk/src/gonacl_appengine/static/pnacl-demo/index.html
(right):

https://codereview.chromium.org/22503002/diff/10001/native_client_sdk/src/gon...
native_client_sdk/src/gonacl_appengine/static/pnacl-demo/index.html:52: display:
none;
With this display: none, the progress bar is not working. I did some debugging
and events are not being delivered to the progress element. When I remove this
"none" (I don't think it's necessary because the progress bar should be
initially shown?) it works

https://codereview.chromium.org/22503002/diff/10001/native_client_sdk/src/gon...
native_client_sdk/src/gonacl_appengine/static/pnacl-demo/index.html:104: <option
value="2">2 Threads</option>
Please set selected="selected" here, on 2 threads

[binji, 2013-08-07 21:23:40]

https://codereview.chromium.org/22503002/diff/10001/native_client_sdk/src/gon...
File native_client_sdk/src/gonacl_appengine/static/pnacl-demo/index.html
(right):

https://codereview.chromium.org/22503002/diff/10001/native_client_sdk/src/gon...
native_client_sdk/src/gonacl_appengine/static/pnacl-demo/index.html:52: display:
none;
On 2013/08/07 19:46:47, eliben wrote:
> With this display: none, the progress bar is not working. I did some debugging
> and events are not being delivered to the progress element. When I remove this
> "none" (I don't think it's necessary because the progress bar should be
> initially shown?) it works

Strange, I just tried it and I saw the progress bar. It will only display when
it gets its first progress event, though (see my change to moduleLoadProgress).

https://codereview.chromium.org/22503002/diff/10001/native_client_sdk/src/gon...
native_client_sdk/src/gonacl_appengine/static/pnacl-demo/index.html:104: <option
value="2">2 Threads</option>
On 2013/08/07 19:46:47, eliben wrote:
> Please set selected="selected" here, on 2 threads

OK, though I'm not certain this will work without forcing a PostMessage() to
update the PEXE as well.

[binji, 2013-08-07 22:10:57]

OK, updated. PTAL

[eliben, 2013-08-07 22:31:28]

lgtm
thanks


On Wed, Aug 7, 2013 at 3:10 PM, <binji@chromium.org> wrote:

> OK, updated. PTAL
>
>
https://codereview.chromium.**org/22503002/<https://codereview.chromium.org/2...
>

[binji, 2013-08-12 17:56:34]

I've made some modifications so they page looks identical on other browsers.
I've tried:

Firefox 23 (and older versions too, 12+)
Safari (not sure which version, but it shouldn't matter)
IE 10 (AFAIK, won't work for anything earlier)
Chrome 28+

[eliben, 2013-08-12 18:02:01]

On 2013/08/12 17:56:34, binji wrote:
> I've made some modifications so they page looks identical on other browsers.
> I've tried:
> 
> Firefox 23 (and older versions too, 12+)
> Safari (not sure which version, but it shouldn't matter)
> IE 10 (AFAIK, won't work for anything earlier)
> Chrome 28+

lgtm, although all that CSS looks like .... to me.

[binji, 2013-08-12 18:08:02]

Committed patchset #7 manually as r217039 (presubmit successful).