Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: milo/appengine/swarming/build_test.go

Issue 2250263005: Milo: Prefetch logs that are failures (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Patch Set: Also add prefetch Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/appengine/swarming/build_test.go
diff --git a/milo/appengine/swarming/build_test.go b/milo/appengine/swarming/build_test.go
index fc422c4975e890953c9b3bf5d38d5855ab275756..8af012183bf97dd838242373ee7d760da2b60716 100644
--- a/milo/appengine/swarming/build_test.go
+++ b/milo/appengine/swarming/build_test.go
@@ -42,7 +42,7 @@ func TestBuild(t *testing.T) {
if *generate {
for _, tc := range getTestCases() {
fmt.Printf("Generating expectations for %s\n", tc)
- build, err := swarmingBuildImpl(c, "foo", "debug", tc)
+ build, _, err := swarmingBuildImpl(c, "foo", "debug", tc)
if err != nil {
panic(fmt.Errorf("Could not run swarmingBuildImpl for %s: %s", tc, err))
}
@@ -62,7 +62,7 @@ func TestBuild(t *testing.T) {
Convey(`A test Environment`, t, func() {
for _, tc := range getTestCases() {
Convey(fmt.Sprintf("Test Case: %s", tc), func() {
- build, err := swarmingBuildImpl(c, "foo", "debug", tc)
+ build, _, err := swarmingBuildImpl(c, "foo", "debug", tc)
So(err, ShouldBeNil)
So(build, shouldMatchExpectationsFor, tc+".json")
})

Powered by Google App Engine
This is Rietveld 408576698