milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-canceled.html - Issue 2250263005: Milo: Prefetch logs that are failures

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-canceled.html

Issue 2250263005: Milo: Prefetch logs that are failures (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: Also add prefetch Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-Basic_successful_build.html ('k') | milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-exception.html » ('j') | milo/appengine/swarming/build.go » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1	1

2 <!DOCTYPE html>	2 <!DOCTYPE html>

3	3

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <title>	5 <title>

6	6

7 Failed	7 Failed

8	8

9 -	9 -

10 infra-continuous-precise-32	10 infra-continuous-precise-32

11 2d8d62f6be545b10	11 2d8d62f6be545b10

12 </title>	12 </title>

13 <link rel="stylesheet" href="/static/buildbot/css/default.css" type="text/css">	13 <link rel="stylesheet" href="/static/buildbot/css/default.css" type="text/css">

14 <script src="/static/common/js/time.js"></script>	14 <script src="/static/common/js/time.js"></script>

15 <script src="/static/common/third_party/js/jquery.min.js"></script>	15 <script src="/static/common/third_party/js/jquery.min.js"></script>

16	16

	17
	agable 2016/08/18 21:44:11 Why do these expectations get extra empty lines? I Why do these expectations get extra empty lines? I mean it's not inherently a bad thing, it just seems like "change X shouldn't touch file Y at all" is a nice invariant to have. Ryan Tseng 2016/08/18 22:09:45 That's because I wasn't using {{- .Statement -}}, Show quoted text On 2016/08/18 21:44:11, agable wrote: > Why do these expectations get extra empty lines? I mean it's not inherently a > bad thing, it just seems like "change X shouldn't touch file Y at all" is a nice > invariant to have. That's because I wasn't using {{- .Statement -}}, so any formatting padding also gets interpreted as padding to get rendered, eg when i added new {{ if stuff }} statements. It's been fixed.
	18

17	19

18 <body class="interface">	20 <body class="interface">

19 <header>	21 <header>

20 Luci	22 Luci

21 </header>	23 </header>

22 <hr>	24 <hr>

23	25

24 <div class="content">	26 <div class="content">

25 <h1>	27 <h1>

26	28

(...skipping 375 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
402 <a href="https://github.com/luci">luci</a>,	404 <a href="https://github.com/luci">luci</a>,

403 working for the <a href="https://chromium.org/">Chromium</a> project.<br>	405 working for the <a href="https://chromium.org/">Chromium</a> project.<br>

404 Page built: <b><span class="local-time" data-timestamp="-6792498672871">Satu rday, 03-Feb-01 04:05:06 UTC</span></b>	406 Page built: <b><span class="local-time" data-timestamp="-6792498672871">Satu rday, 03-Feb-01 04:05:06 UTC</span></b>

405 </footer>	407 </footer>

406 <script>	408 <script>

407 (function () {	409 (function () {

408 'use strict';	410 'use strict';

409 milo.makeTimesLocal();	411 milo.makeTimesLocal();

410 })();	412 })();

411 </script>	413 </script>

OLD	NEW