extensions/renderer/script_injector.h - Issue 2250263004: [Extensions] Reduce string copy in renderer/ UserScript.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/script_injector.h

Issue 2250263004: [Extensions] Reduce string copy in renderer/ UserScript. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/script_injector.h

diff --git a/extensions/renderer/script_injector.h b/extensions/renderer/script_injector.h

index 2443942e652715c2833e87050925ed716bcd4ebb..0ed69f73d2a6e12a5cf6200a6d3214936b5c5d65 100644

--- a/extensions/renderer/script_injector.h

+++ b/extensions/renderer/script_injector.h

@@ -69,7 +69,7 @@ class ScriptInjector {

// Returns the css to inject at the given |run_location|.

// Only called if ShouldInjectCss() is true.

- virtual std::vector<std::string> GetCssSources(

+ virtual std::vector<blink::WebString> GetCssSources(

UserScript::RunLocation run_location) const = 0;

// Fill scriptrs run info based on information about injection.

« no previous file with comments | « extensions/renderer/script_injection.cc ('k') | extensions/renderer/user_script_injector.h » ('j') | no next file with comments »