extensions/renderer/programmatic_script_injector.h - Issue 2250263004: [Extensions] Reduce string copy in renderer/ UserScript.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/programmatic_script_injector.h

Issue 2250263004: [Extensions] Reduce string copy in renderer/ UserScript. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/programmatic_script_injector.h

diff --git a/extensions/renderer/programmatic_script_injector.h b/extensions/renderer/programmatic_script_injector.h

index 885c3b12151cc2fc9b4d5ecf686b0e40ddc198cb..b408d58a34a1ed5ada9774e8e417facd925c9cd8 100644

--- a/extensions/renderer/programmatic_script_injector.h

+++ b/extensions/renderer/programmatic_script_injector.h

@@ -41,7 +41,7 @@ class ProgrammaticScriptInjector : public ScriptInjector {

int tab_id) const override;

std::vector<blink::WebScriptSource> GetJsSources(

UserScript::RunLocation run_location) const override;

- std::vector<std::string> GetCssSources(

+ std::vector<blink::WebString> GetCssSources(

UserScript::RunLocation run_location) const override;

void GetRunInfo(ScriptsRunInfo* scripts_run_info,

UserScript::RunLocation run_location) const override;

« no previous file with comments | « extensions/renderer/dispatcher.cc ('k') | extensions/renderer/programmatic_script_injector.cc » ('j') | no next file with comments »