Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 225023038: Revert of Hook up gin platform to blink, and explicitly manage the main thread isolate (Closed)

Created:
6 years, 8 months ago by yurys
Modified:
6 years, 8 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Revert of Hook up gin platform to blink, and explicitly manage the main thread isolate (https://codereview.chromium.org/227653002/) Reason for revert: Broke browser_tests on Linux: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/35802 Original issue's description: > Hook up gin platform to blink, and explicitly manage the main thread isolate > > We'll soon get rid of the v8 default isolate, so we'll need to manage > our own. > > To test the platform implementation, run with > --js-flags="--noparallel_sweeping --concurrent-sweeping --job-based-sweeping" > > BUG=359977 > R=dcarney@chromium.org,haraken@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171036 TBR=dcarney@chromium.org,haraken@chromium.org,jochen@chromium.org NOTREECHECKS=true NOTRY=true BUG=359977 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171053

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M Source/web/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebKit.cpp View 3 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
Created Revert of Hook up gin platform to blink, and explicitly manage the main thread ...
6 years, 8 months ago (2014-04-08 12:36:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/225023038/1
6 years, 8 months ago (2014-04-08 12:36:19 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-08 12:36:35 UTC) #3
Message was sent while issue was closed.
Change committed as 171053

Powered by Google App Engine
This is Rietveld 408576698