Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: cc/resources/picture.cc

Issue 225023031: Hack SkRecord in as an alternate recording mode in cc/resources/picture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase? Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/picture.h ('k') | cc/resources/picture_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/picture.cc
diff --git a/cc/resources/picture.cc b/cc/resources/picture.cc
index 48f03e0ba842a864975eef07cb8e19cf2988db4f..de6ff93506f7a85ac2ed7bbaae4f8000dcc97fcd 100644
--- a/cc/resources/picture.cc
+++ b/cc/resources/picture.cc
@@ -192,6 +192,11 @@ Picture::~Picture() {
}
Picture* Picture::GetCloneForDrawingOnThread(unsigned thread_index) {
+ // We don't need clones to draw from multiple threads with SkRecord.
+ if (playback_) {
+ return this;
+ }
+
// SkPicture is not thread-safe to rasterize with, this returns a clone
// to rasterize with on a specific thread.
CHECK_GE(clones_.size(), thread_index);
@@ -214,6 +219,11 @@ bool Picture::IsSuitableForGpuRasterization() const {
void Picture::CloneForDrawing(int num_threads) {
TRACE_EVENT1("cc", "Picture::CloneForDrawing", "num_threads", num_threads);
+ // We don't need clones to draw from multiple threads with SkRecord.
+ if (playback_) {
+ return;
+ }
+
DCHECK(picture_);
DCHECK(clones_.empty());
@@ -254,6 +264,8 @@ void Picture::Record(ContentLayerClient* painter,
SkTileGridFactory factory(tile_grid_info);
SkPictureRecorder recorder;
+ scoped_ptr<EXPERIMENTAL::SkRecording> recording;
+
skia::RefPtr<SkCanvas> canvas;
canvas = skia::SharePtr(
recorder.beginRecording(layer_rect_.width(),
@@ -273,6 +285,11 @@ void Picture::Record(ContentLayerClient* painter,
// canvas.
canvas.clear();
break;
+ case RECORD_WITH_SKRECORD:
+ recording.reset(new EXPERIMENTAL::SkRecording(layer_rect_.width(),
+ layer_rect_.height()));
+ canvas = skia::SharePtr(recording->canvas());
+ break;
default:
NOTREACHED();
}
@@ -297,6 +314,13 @@ void Picture::Record(ContentLayerClient* painter,
picture_ = skia::AdoptRef(recorder.endRecording());
DCHECK(picture_);
+ if (recording) {
+ // SkRecording requires it's the only one holding onto canvas before we
+ // may call releasePlayback(). (This helps enforce thread-safety.)
+ canvas.clear();
+ playback_.reset(recording->releasePlayback());
+ }
+
opaque_rect_ = gfx::ToEnclosedRect(opaque_layer_rect);
EmitTraceSnapshot();
@@ -379,7 +403,11 @@ int Picture::Raster(
canvas->scale(contents_scale, contents_scale);
canvas->translate(layer_rect_.x(), layer_rect_.y());
- picture_->draw(canvas, callback);
+ if (playback_) {
+ playback_->draw(canvas);
+ } else {
+ picture_->draw(canvas, callback);
+ }
SkIRect bounds;
canvas->getClipDeviceBounds(&bounds);
canvas->restore();
@@ -394,7 +422,11 @@ void Picture::Replay(SkCanvas* canvas) {
TRACE_EVENT_BEGIN0("cc", "Picture::Replay");
DCHECK(picture_);
- picture_->draw(canvas);
+ if (playback_) {
+ playback_->draw(canvas);
+ } else {
+ picture_->draw(canvas);
+ }
SkIRect bounds;
canvas->getClipDeviceBounds(&bounds);
TRACE_EVENT_END1("cc", "Picture::Replay",
« no previous file with comments | « cc/resources/picture.h ('k') | cc/resources/picture_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698