Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 225023029: Apply SVG paint-order to text-decorations (Closed)

Created:
6 years, 8 months ago by fs
Modified:
6 years, 8 months ago
CC:
blink-reviews, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink
Visibility:
Public.

Description

Apply SVG paint-order to text-decorations BUG=360571 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171070

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -11 lines) Patch
A LayoutTests/svg/paintorder/paintorder-text-decorations.svg View 1 chunk +37 lines, -0 lines 3 comments Download
A LayoutTests/svg/paintorder/paintorder-text-decorations-expected.svg View 1 chunk +66 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.cpp View 1 chunk +19 lines, -11 lines 2 comments Download

Messages

Total messages: 15 (0 generated)
fs
6 years, 8 months ago (2014-04-07 14:36:13 UTC) #1
fs
Seems the F2F is just too much fun...
6 years, 8 months ago (2014-04-08 13:44:45 UTC) #2
Stephen Chennney
LGTM. I presume the spec says that text decoration is still painted after text, or ...
6 years, 8 months ago (2014-04-08 14:14:31 UTC) #3
pdr.
LGTM with a nit and a suggestion https://codereview.chromium.org/225023029/diff/1/LayoutTests/svg/paintorder/paintorder-text-decorations.svg File LayoutTests/svg/paintorder/paintorder-text-decorations.svg (right): https://codereview.chromium.org/225023029/diff/1/LayoutTests/svg/paintorder/paintorder-text-decorations.svg#newcode3 LayoutTests/svg/paintorder/paintorder-text-decorations.svg:3: <marker id="m" ...
6 years, 8 months ago (2014-04-08 14:20:57 UTC) #4
Stephen Chennney
https://codereview.chromium.org/225023029/diff/1/LayoutTests/svg/paintorder/paintorder-text-decorations.svg File LayoutTests/svg/paintorder/paintorder-text-decorations.svg (right): https://codereview.chromium.org/225023029/diff/1/LayoutTests/svg/paintorder/paintorder-text-decorations.svg#newcode3 LayoutTests/svg/paintorder/paintorder-text-decorations.svg:3: <marker id="m" refX="5" refY="5" viewBox="0 0 10 10" overflow="visible"> ...
6 years, 8 months ago (2014-04-08 15:06:10 UTC) #5
fs
On 2014/04/08 14:14:31, Stephen Chenney wrote: > LGTM. I presume the spec says that text ...
6 years, 8 months ago (2014-04-08 15:39:00 UTC) #6
fs
On 2014/04/08 15:39:00, fs wrote: > On 2014/04/08 14:14:31, Stephen Chenney wrote: > > LGTM. ...
6 years, 8 months ago (2014-04-08 15:43:47 UTC) #7
fs
https://codereview.chromium.org/225023029/diff/1/LayoutTests/svg/paintorder/paintorder-text-decorations.svg File LayoutTests/svg/paintorder/paintorder-text-decorations.svg (right): https://codereview.chromium.org/225023029/diff/1/LayoutTests/svg/paintorder/paintorder-text-decorations.svg#newcode3 LayoutTests/svg/paintorder/paintorder-text-decorations.svg:3: <marker id="m" refX="5" refY="5" viewBox="0 0 10 10" overflow="visible"> ...
6 years, 8 months ago (2014-04-08 15:50:23 UTC) #8
fs
The CQ bit was checked by fs@opera.com
6 years, 8 months ago (2014-04-08 16:19:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/225023029/1
6 years, 8 months ago (2014-04-08 16:19:38 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-08 16:42:34 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 8 months ago (2014-04-08 16:42:34 UTC) #12
fs
The CQ bit was checked by fs@opera.com
6 years, 8 months ago (2014-04-08 17:05:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/225023029/1
6 years, 8 months ago (2014-04-08 17:05:59 UTC) #14
commit-bot: I haz the power
6 years, 8 months ago (2014-04-08 17:46:00 UTC) #15
Message was sent while issue was closed.
Change committed as 171070

Powered by Google App Engine
This is Rietveld 408576698