Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 225023020: IDBFactoryBackend -> IndexedDBClient, remove indexeddb/chromium (Closed)

Created:
6 years, 8 months ago by jsbell
Modified:
6 years, 8 months ago
CC:
blink-reviews, dgrogan, jsbell+idb_chromium.org, alecflett, ericu+idb_chromium.org, cmumford
Visibility:
Public.

Description

IDBFactoryBackend -> IndexedDBClient, remove indexeddb/chromium Tidy up some naming and layering split from the WebKit days. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171425

Patch Set 1 #

Patch Set 2 : Lingering header references #

Patch Set 3 : rebased #

Patch Set 4 : IndexedDB.cpp -> IndexedDBClient.cpp #

Total comments: 1

Patch Set 5 : Rename some lingering 'factory' ferences to 'client' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -304 lines) Patch
M Source/modules/indexeddb/DOMWindowIndexedDatabase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/DOMWindowIndexedDatabase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBFactory.h View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/indexeddb/IDBFactory.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D Source/modules/indexeddb/IDBFactoryBackendInterface.h View 1 chunk +0 lines, -50 lines 0 comments Download
A + Source/modules/indexeddb/IndexedDBClient.h View 1 2 3 2 chunks +10 lines, -7 lines 0 comments Download
A Source/modules/indexeddb/IndexedDBClient.cpp View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
M Source/modules/indexeddb/WorkerGlobalScopeIndexedDatabase.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/WorkerGlobalScopeIndexedDatabase.cpp View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
D Source/modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.h View 1 chunk +0 lines, -41 lines 0 comments Download
D Source/modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.cpp View 1 chunk +0 lines, -48 lines 0 comments Download
M Source/modules/modules.gypi View 1 2 3 3 chunks +2 lines, -3 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D Source/web/IDBFactoryBackendProxy.h View 1 chunk +0 lines, -54 lines 0 comments Download
D Source/web/IDBFactoryBackendProxy.cpp View 1 2 1 chunk +0 lines, -68 lines 0 comments Download
A + Source/web/IndexedDBClientImpl.h View 1 2 3 2 chunks +8 lines, -9 lines 0 comments Download
A + Source/web/IndexedDBClientImpl.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M Source/web/WebKit.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/web.gypi View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
jsbell
Inspired by jam@'s crrev.com/225303007 - let's rename/collapse these to match other client classes. dglazkov@, jam@ ...
6 years, 8 months ago (2014-04-04 23:46:46 UTC) #1
jam
just to be clear: i'm not an owner/reviewer in blink
6 years, 8 months ago (2014-04-04 23:52:38 UTC) #2
jsbell
On 2014/04/04 23:52:38, jam wrote: > just to be clear: i'm not an owner/reviewer in ...
6 years, 8 months ago (2014-04-05 00:11:04 UTC) #3
jsbell
Compile fail on android was unrelated. dglazkov@, abarth@ - PTAL?
6 years, 8 months ago (2014-04-07 17:47:23 UTC) #4
jam
On 2014/04/05 00:11:04, jsbell wrote: > On 2014/04/04 23:52:38, jam wrote: > > just to ...
6 years, 8 months ago (2014-04-07 18:08:36 UTC) #5
jsbell
huh, not entirely sure why I had added IndexedDB.cpp. Moved it to IndexedDBClient.cpp instead, which ...
6 years, 8 months ago (2014-04-09 23:20:30 UTC) #6
abarth-chromium
lgtm https://codereview.chromium.org/225023020/diff/60001/Source/modules/indexeddb/IDBFactory.h File Source/modules/indexeddb/IDBFactory.h (right): https://codereview.chromium.org/225023020/diff/60001/Source/modules/indexeddb/IDBFactory.h#newcode48 Source/modules/indexeddb/IDBFactory.h:48: static PassRefPtr<IDBFactory> create(IndexedDBClient* factory) s/factory/client/ ?
6 years, 8 months ago (2014-04-10 00:33:44 UTC) #7
jsbell
On 2014/04/10 00:33:44, abarth wrote: > lgtm > > https://codereview.chromium.org/225023020/diff/60001/Source/modules/indexeddb/IDBFactory.h > File Source/modules/indexeddb/IDBFactory.h (right): > ...
6 years, 8 months ago (2014-04-11 23:32:45 UTC) #8
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 8 months ago (2014-04-11 23:32:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/225023020/80001
6 years, 8 months ago (2014-04-11 23:32:53 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-12 00:24:51 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-12 00:24:52 UTC) #12
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 8 months ago (2014-04-12 18:56:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/225023020/80001
6 years, 8 months ago (2014-04-12 18:56:44 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-12 19:32:54 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-12 19:32:54 UTC) #16
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 8 months ago (2014-04-14 06:09:00 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/225023020/80001
6 years, 8 months ago (2014-04-14 06:09:08 UTC) #18
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 06:38:17 UTC) #19
Message was sent while issue was closed.
Change committed as 171425

Powered by Google App Engine
This is Rietveld 408576698