Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 225023014: Revert of Reapply "Media Galleries API Metadata: Image metadata" (Closed)

Created:
6 years, 8 months ago by tommycli
Modified:
6 years, 8 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, dyu1, vandebo (ex-Chrome), grt+watch_chromium.org, tommycli, anantha, Greg Billock, dennis_jeffrey, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org
Visibility:
Public.

Description

Revert of Reapply "Media Galleries API Metadata: Image metadata" (https://codereview.chromium.org/216443005/) Reason for revert: Breaking Mac 10.6 release testers. (no idea why, but it is) Original issue's description: > Reapply "Media Galleries API Metadata: Image metadata" > > Original patch (also PS1) https://codereview.chromium.org/191583002 > > CQ can't catch the breakages of this patch. > > TBR= > BUG=318450 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261864 TBR=ccameron@chromium.org,thestig@chromium.org,grt@chromium.org NOTREECHECKS=true NOTRY=true BUG=318450 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261895

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -605 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/chrome.gyp View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/chrome.isolate View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome_dll_bundle.gypi View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/media_galleries.idl View 1 chunk +1 line, -14 lines 0 comments Download
M chrome/installer/linux/debian/expected_deps View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/linux/rpm/expected_deps_i386 View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/linux/rpm/expected_deps_x86_64 View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/linux/sysroot_scripts/packagelist.debian.wheezy.amd64 View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/interactive_ui_tests.isolate View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/sync_integration_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/media_galleries/media_metadata/test.js View 2 chunks +1 line, -23 lines 0 comments Download
M chrome/tools/build/chromeos/FILES.cfg View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/tools/build/mac/TESTS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/tools/build/mac/dump_product_syms View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/unit_tests.isolate View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/utility/media_galleries/image_metadata_extractor.h View 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/utility/media_galleries/image_metadata_extractor.cc View 1 chunk +0 lines, -279 lines 0 comments Download
D chrome/utility/media_galleries/image_metadata_extractor_unittest.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M chrome/utility/media_galleries/media_metadata_parser.cc View 5 chunks +0 lines, -57 lines 0 comments Download
M content/content_browsertests.isolate View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/libexif/libexif.gyp View 3 chunks +15 lines, -28 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tommycli
Created Revert of Reapply "Media Galleries API Metadata: Image metadata"
6 years, 8 months ago (2014-04-04 21:50:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/225023014/1
6 years, 8 months ago (2014-04-04 21:50:42 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-04 22:02:07 UTC) #3
Message was sent while issue was closed. 
Change committed as 261895

Powered by Google App Engine
This is Rietveld 408576698