Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Unified Diff: media/cast/test/utility/in_process_receiver.h

Issue 225023010: [Cast] Refactor/clean-up VideoReceiver to match AudioReceiver as closely as possible. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/test/end2end_unittest.cc ('k') | media/cast/test/utility/in_process_receiver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/test/utility/in_process_receiver.h
diff --git a/media/cast/test/utility/in_process_receiver.h b/media/cast/test/utility/in_process_receiver.h
index de18845bfbcad04d12713bcc795dd232ad441a77..d50514fb638ac2dfba7a4c08767611894b4392c1 100644
--- a/media/cast/test/utility/in_process_receiver.h
+++ b/media/cast/test/utility/in_process_receiver.h
@@ -78,7 +78,7 @@ class InProcessReceiver {
const base::TimeTicks& playout_time,
bool is_continuous) = 0;
virtual void OnVideoFrame(const scoped_refptr<VideoFrame>& video_frame,
- const base::TimeTicks& render_time,
+ const base::TimeTicks& playout_time,
bool is_continuous) = 0;
// Helper method that creates |transport_| and |cast_receiver_|, starts
@@ -97,12 +97,15 @@ class InProcessReceiver {
private:
friend class base::RefCountedThreadSafe<InProcessReceiver>;
- // CastReceiver callbacks that receive a frame and then request another.
+ // CastReceiver callbacks that receive a frame and then request another. See
+ // comments for the callbacks defined in src/media/cast/cast_receiver.h for
+ // argument description and semantics.
void GotAudioFrame(scoped_ptr<AudioBus> audio_frame,
const base::TimeTicks& playout_time,
bool is_continuous);
void GotVideoFrame(const scoped_refptr<VideoFrame>& video_frame,
- const base::TimeTicks& render_time);
+ const base::TimeTicks& playout_time,
+ bool is_continuous);
void PullNextAudioFrame();
void PullNextVideoFrame();
« no previous file with comments | « media/cast/test/end2end_unittest.cc ('k') | media/cast/test/utility/in_process_receiver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698