[Cast] Refactor/clean-up VideoReceiver to match AudioReceiver as closely as possible.

media/cast/test/utility/in_process_receiver.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_CAST_TEST_IN_PROCESS_RECEIVER_H_
 #define MEDIA_CAST_TEST_IN_PROCESS_RECEIVER_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
@@ skipping 57 matching lines @@
   // Destroy the sub-compontents of this class.
   // After this call, it is safe to destroy this object on any thread.
   void Stop();
 
  protected:
   // To be implemented by subclasses.  These are called on the Cast MAIN thread
   // as each frame is received.
   virtual void OnAudioFrame(scoped_ptr<PcmAudioFrame> audio_frame,
                             const base::TimeTicks& playout_time) = 0;
   virtual void OnVideoFrame(const scoped_refptr<VideoFrame>& video_frame,
-                            const base::TimeTicks& render_time) = 0;
+                            const base::TimeTicks& playout_time) = 0;
 
   // Helper method that creates |transport_| and |cast_receiver_|, starts
   // |transport_| receiving, and requests the first audio/video frame.
   // Subclasses may override to provide additional start-up functionality.
   virtual void StartOnMainThread();
 
   // Helper method that destroys |transport_| and |cast_receiver_|.
   // Subclasses may override to provide additional start-up functionality.
   virtual void StopOnMainThread(base::WaitableEvent* event);
 
   // Callback for the transport to notify of status changes.  A default
   // implementation is provided here that simply logs socket errors.
   virtual void UpdateCastTransportStatus(transport::CastTransportStatus status);
 
  private:
   friend class base::RefCountedThreadSafe<InProcessReceiver>;
 
   // CastReceiver callbacks that receive a frame and then request another.
   void GotAudioFrame(scoped_ptr<AudioBus> audio_frame,
                      const base::TimeTicks& playout_time,
                      bool is_continuous);
   void GotVideoFrame(const scoped_refptr<VideoFrame>& video_frame,
-                     const base::TimeTicks& render_time);
+                     const base::TimeTicks& playout_time,
+                     bool is_continuous);

[hubbe, 2014/04/07 18:40:17]

Document |is_continuous| (and perhaps the entire method)

[miu, 2014/04/08 00:59:41]

Done.  But, rather than duplicate comments, I've pointed the reader to
cast_receiver.h.

   void PullNextAudioFrame();
   void PullNextVideoFrame();
 
   // Invoked just before the destruction of |receiver| on the cast MAIN thread.
   static void WillDestroyReceiver(InProcessReceiver* receiver);
 
   const scoped_refptr<CastEnvironment> cast_environment_;
   const net::IPEndPoint local_end_point_;
   const net::IPEndPoint remote_end_point_;
   const AudioReceiverConfig audio_config_;
   const VideoReceiverConfig video_config_;
 
   scoped_ptr<transport::UdpTransport> transport_;
   scoped_ptr<CastReceiver> cast_receiver_;
 
   // NOTE: Weak pointers must be invalidated before all other member variables.
   base::WeakPtrFactory<InProcessReceiver> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(InProcessReceiver);
 };
 
 }  // namespace cast
 }  // namespace media
 
 #endif  // MEDIA_CAST_TEST_IN_PROCESS_RECEIVER_H_