 Chromium Code Reviews
 Chromium Code Reviews Issue 225023010:
  [Cast] Refactor/clean-up VideoReceiver to match AudioReceiver as closely as possible.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src
    
  
    Issue 225023010:
  [Cast] Refactor/clean-up VideoReceiver to match AudioReceiver as closely as possible.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src| OLD | NEW | 
|---|---|
| 1 // Copyright 2013 The Chromium Authors. All rights reserved. | 1 // Copyright 2013 The Chromium Authors. All rights reserved. | 
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be | 
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. | 
| 4 | 4 | 
| 5 #ifndef MEDIA_CAST_CAST_RECEIVER_IMPL_H_ | 5 #ifndef MEDIA_CAST_CAST_RECEIVER_IMPL_H_ | 
| 6 #define MEDIA_CAST_CAST_RECEIVER_IMPL_H_ | 6 #define MEDIA_CAST_CAST_RECEIVER_IMPL_H_ | 
| 7 | 7 | 
| 8 #include "base/memory/ref_counted.h" | 8 #include "base/memory/ref_counted.h" | 
| 9 #include "base/memory/scoped_ptr.h" | 9 #include "base/memory/scoped_ptr.h" | 
| 10 #include "media/cast/audio_receiver/audio_receiver.h" | 10 #include "media/cast/audio_receiver/audio_receiver.h" | 
| (...skipping 19 matching lines...) Expand all Loading... | |
| 30 | 30 | 
| 31 // All received RTP and RTCP packets for the call should be sent to this | 31 // All received RTP and RTCP packets for the call should be sent to this | 
| 32 // PacketReceiver; | 32 // PacketReceiver; | 
| 33 virtual transport::PacketReceiverCallback packet_receiver() OVERRIDE; | 33 virtual transport::PacketReceiverCallback packet_receiver() OVERRIDE; | 
| 34 | 34 | 
| 35 // Interface to get audio and video frames from the CastReceiver. | 35 // Interface to get audio and video frames from the CastReceiver. | 
| 36 virtual scoped_refptr<FrameReceiver> frame_receiver() OVERRIDE; | 36 virtual scoped_refptr<FrameReceiver> frame_receiver() OVERRIDE; | 
| 37 | 37 | 
| 38 private: | 38 private: | 
| 39 void ReceivedPacket(scoped_ptr<Packet> packet); | 39 void ReceivedPacket(scoped_ptr<Packet> packet); | 
| 40 void UpdateTargetDelay(base::TimeDelta target_delay_ms); | |
| 
hubbe
2014/04/07 18:40:17
Why are we deleting this?
 
miu
2014/04/08 00:59:41
It's a dead code path (no caller).  I'm the owner
 | |
| 41 | 40 | 
| 42 transport::PacedSender pacer_; | 41 transport::PacedSender pacer_; | 
| 43 AudioReceiver audio_receiver_; | 42 AudioReceiver audio_receiver_; | 
| 44 VideoReceiver video_receiver_; | 43 VideoReceiver video_receiver_; | 
| 45 scoped_refptr<FrameReceiver> frame_receiver_; | 44 scoped_refptr<FrameReceiver> frame_receiver_; | 
| 46 scoped_refptr<CastEnvironment> cast_environment_; | 45 scoped_refptr<CastEnvironment> cast_environment_; | 
| 47 const uint32 ssrc_of_audio_sender_; | 46 const uint32 ssrc_of_audio_sender_; | 
| 48 const uint32 ssrc_of_video_sender_; | 47 const uint32 ssrc_of_video_sender_; | 
| 49 | 48 | 
| 50 DISALLOW_COPY_AND_ASSIGN(CastReceiverImpl); | 49 DISALLOW_COPY_AND_ASSIGN(CastReceiverImpl); | 
| 51 }; | 50 }; | 
| 52 | 51 | 
| 53 } // namespace cast | 52 } // namespace cast | 
| 54 } // namespace media | 53 } // namespace media | 
| 55 | 54 | 
| 56 #endif // MEDIA_CAST_CAST_RECEIVER_IMPL_ | 55 #endif // MEDIA_CAST_CAST_RECEIVER_IMPL_ | 
| OLD | NEW |