[Cast] Refactor/clean-up VideoReceiver to match AudioReceiver as closely as possible.

media/cast/cast_config.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/cast/cast_config.h"
 
 namespace media {
 namespace cast {
 
+// TODO(miu): Revisit code factoring of these structs.

[hubbe, 2014/04/07 18:40:17]

I don't understand this TODO.

[miu, 2014/04/08 00:59:41]

Added detail.

+
+// TODO(miu): Make sure all POD members are initialized by ctors.  Policy
+// decision: Reasonable defaults or use invalid placeholder values to expose
+// unset members?
+
+// TODO(miu): Provide IsValidConfig() functions?
+
+// TODO(miu): Throughout the code, there is a lot of copy-and-paste of the same
+// calculations based on these config values.  So, why don't we add methods to
+// these classes to centralize the logic?
+
 VideoSenderConfig::VideoSenderConfig()
     : sender_ssrc(0),
       incoming_feedback_ssrc(0),
       rtcp_interval(kDefaultRtcpIntervalMs),
       rtcp_mode(kRtcpReducedSize),
       use_external_encoder(false),
       width(0),
       height(0),
       congestion_control_back_off(kDefaultCongestionControlBackOff),
+      max_bitrate(5000000),
+      min_bitrate(1000000),
+      start_bitrate(5000000),
       max_qp(kDefaultMaxQp),
       min_qp(kDefaultMinQp),
       max_frame_rate(kDefaultMaxFrameRate),
-      max_number_of_video_buffers_used(kDefaultNumberOfVideoBuffers) {}
+      max_number_of_video_buffers_used(kDefaultNumberOfVideoBuffers),
+      codec(transport::kVp8),
+      number_of_cores(0) {}
 
 AudioSenderConfig::AudioSenderConfig()
     : sender_ssrc(0),
       incoming_feedback_ssrc(0),
       rtcp_interval(kDefaultRtcpIntervalMs),
       rtcp_mode(kRtcpReducedSize),
       use_external_encoder(false),
       frequency(0),
       channels(0),
       bitrate(0) {}
@@ skipping 11 matching lines @@
 
 VideoReceiverConfig::VideoReceiverConfig()
     : feedback_ssrc(0),
       incoming_ssrc(0),
       rtcp_interval(kDefaultRtcpIntervalMs),
       rtcp_mode(kRtcpReducedSize),
       rtp_max_delay_ms(kDefaultRtpMaxDelayMs),
       rtp_payload_type(0),
       use_external_decoder(false),
       max_frame_rate(kDefaultMaxFrameRate),
-      decoder_faster_than_max_frame_rate(true) {}
+      decoder_faster_than_max_frame_rate(true),
+      codec(transport::kVp8) {}
 
 PcmAudioFrame::PcmAudioFrame() {}
 PcmAudioFrame::~PcmAudioFrame() {}
 
 }  // namespace cast
 }  // namespace media