Reland 261559: Create new app_shell.gyp for app_shell targets.

Reland 261559: Create new app_shell.gyp for app_shell targets.

This moves app_shell GYP entries from a chrome.gyp include into
a new apps/shell/app_shell.gyp.

It also breaks down dependencies with more granularity and separates
temporary undesirable app_shell_lib dependencies from acceptable ones.

This was reverted due to a bug in the gyp file breaking a builder.
app_shell_temporary_deps should not have been a static_library target.

BUG=359678
TBR=yoz@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261800

[Ken Rockot(use gerrit already), 2014-04-04 00:25:21]

Yoyo, do you agree that the error seen here:

http://build.chromium.org/p/chromium/builders/Win/builds/20191/steps/compile/...

should be resolved by changing app_shell_temporary_deps target type to 'none'?

[Yoyo Zhou, 2014-04-04 01:04:35]

https://codereview.chromium.org/225023002/diff/1/apps/shell/app_shell.gyp
File apps/shell/app_shell.gyp (right):

https://codereview.chromium.org/225023002/diff/1/apps/shell/app_shell.gyp#new...
apps/shell/app_shell.gyp:55: 'target_name': 'app_shell_temporary_deps',
Actually, now that I think about it, I don't think we should be making a
separate target here. none *might* work, but...

gyp does certain things differently when targets are directly included in
dependencies (e.g. export_dependent_settings only applies to direct dependers,
not transitive dependers).

Given that we have a "temporary above here" advisory on app_shell_lib, can we
fold this into that section?

[Ken Rockot(use gerrit already), 2014-04-04 01:11:33]

On 2014/04/04 01:04:35, Yoyo Zhou wrote:
> https://codereview.chromium.org/225023002/diff/1/apps/shell/app_shell.gyp
> File apps/shell/app_shell.gyp (right):
> 
>
https://codereview.chromium.org/225023002/diff/1/apps/shell/app_shell.gyp#new...
> apps/shell/app_shell.gyp:55: 'target_name': 'app_shell_temporary_deps',
> Actually, now that I think about it, I don't think we should be making a
> separate target here. none *might* work, but...
> 
> gyp does certain things differently when targets are directly included in
> dependencies (e.g. export_dependent_settings only applies to direct dependers,
> not transitive dependers).
> 
> Given that we have a "temporary above here" advisory on app_shell_lib, can we
> fold this into that section?

Yeah, SGTM. Done.

[James Cook, 2014-04-04 03:47:00]

Drive-by comment.

https://codereview.chromium.org/225023002/diff/40001/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/225023002/diff/40001/build/all.gyp#newcode226
build/all.gyp:226: ['chromeos==1 or (OS=="linux" and use_aura==1) or (OS=="win"
and use_aura==1)', {
As I commented on the other code review, we might want to just stop building
app_shell on windows.

[Ken Rockot(use gerrit already), 2014-04-04 03:51:32]

SGTM


On Thu, Apr 3, 2014 at 8:47 PM, <jamescook@chromium.org> wrote:

> Drive-by comment.
>
>
> https://codereview.chromium.org/225023002/diff/40001/build/all.gyp
> File build/all.gyp (right):
>
> https://codereview.chromium.org/225023002/diff/40001/
> build/all.gyp#newcode226
> build/all.gyp:226: ['chromeos==1 or (OS=="linux" and use_aura==1) or
> (OS=="win" and use_aura==1)', {
> As I commented on the other code review, we might want to just stop
> building app_shell on windows.
>
> https://codereview.chromium.org/225023002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ken Rockot(use gerrit already), 2014-04-04 04:09:45]

all.gyp updated to not build app_shell.gyp:* on windows.

[James Cook, 2014-04-04 15:42:35]

+Hokein as FYI - we've burned some time in the last couple days due to Windows
support. We're going to turn off app_shell on Windows for now.  We can look at
re-enabling it on Windows in a few weeks, when it's more mature.

[Ken Rockot(use gerrit already), 2014-04-04 18:37:06]

Committed patchset #4 manually as r261800 (presubmit successful).

[Haojian Wu, 2014-04-05 14:35:31]

On 2014/04/04 15:42:35, James Cook wrote:
> +Hokein as FYI - we've burned some time in the last couple days due to Windows
> support. We're going to turn off app_shell on Windows for now.  We can look at
> re-enabling it on Windows in a few weeks, when it's more mature.

Get it. Thanks. I'm busy with other staff these days.