components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h - Issue 2250223002: Add InfoBar delegate for previews

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h

Issue 2250223002: Add InfoBar delegate for previews (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_service.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h

index 1f1905c4eaef469f5d080478a8bcd4d6bc3479e0..47feee4d3c20ce823bb71136797139eb71b39485 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h

@@ -135,16 +135,16 @@ class DataReductionProxySettings : public DataReductionProxyServiceObserver,

// the last main frame request.

bool WasLoFiLoadImageRequestedBefore();

- // Increments the number of times the Lo-Fi snackbar has been shown.

- void IncrementLoFiSnackbarShown();

+ // Increments the number of times the Lo-Fi UI has been shown.

+ void IncrementLoFiUIShown();

// Sets |lo_fi_load_image_requested_| to true, which means a "Load image"

// context menu request has been made since the last main frame request.

void SetLoFiLoadImageRequested();

// Counts the number of requests to reload the page with images from the Lo-Fi

- // snackbar. If the user requests the page with images a certain number of

- // times, then Lo-Fi is disabled for the remainder of the session.

+ // UI. If the user requests the page with images a certain number of times,

+ // then Lo-Fi is disabled for the remainder of the session.

void IncrementLoFiUserRequestsForImages();

// Records UMA for Lo-Fi implicit opt out actions.

@@ -302,8 +302,7 @@ class DataReductionProxySettings : public DataReductionProxyServiceObserver,

bool lo_fi_load_image_requested_;

// The number of requests to reload the page with images from the Lo-Fi

- // snackbar until Lo-Fi is disabled for the remainder of the

- // session.

+ // UI until Lo-Fi is disabled for the remainder of the session.

int lo_fi_user_requests_for_images_per_session_;

// The number of consecutive sessions where Lo-Fi was disabled for