Add InfoBar delegate for previews

chrome/browser/previews/previews_infobar_delegate.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PREVIEWS_PREVIEWS_INFOBAR_DELEGATE_H_
+#define CHROME_BROWSER_PREVIEWS_PREVIEWS_INFOBAR_DELEGATE_H_
+
+#include "components/infobars/core/confirm_infobar_delegate.h"
+
+namespace content {
+class WebContents;
+}
+
+class PreviewsInfoBarDelegate : public ConfirmInfoBarDelegate {

[bengr, 2016/08/25 23:26:19]

Please add a class comment.

[megjablon, 2016/08/26 22:47:30]

Done.

+ public:
+  // The type of the infobar. It controls the strings and what UMA data is

[bengr, 2016/08/25 23:26:19]

Strings shoudn't be affected.

[megjablon, 2016/08/26 22:47:30]

The offline infobar gets "Faster page loaded." instead of the "Saved data."

+  // recorded for the infobar.
+  enum PreviewsInfoBarType {
+    LOFI,      // Server-side image replacement.
+    LITE_PAGE, // Server-side page rewrite.
+    OFFLINE,   // Offline copy of the page.
+  };
+
+  ~PreviewsInfoBarDelegate() override;
+
+  // Creates a preview infobar and corresponding delegate and adds the infobar
+  // to InfoBarService.
+  static void Create(content::WebContents* web_contents,
+                     PreviewsInfoBarType infobar_type);
+
+ private:
+  PreviewsInfoBarDelegate(content::WebContents* web_contents,
+                          PreviewsInfoBarType infobar_type);
+
+  // ConfirmInfoBarDelegate:

[bengr, 2016/08/25 23:26:19]

add the word "overrides"

[megjablon, 2016/08/26 22:47:30]

Adding this back in. pkasting asked me to remove it.

[Peter Kasting, 2016/08/27 03:42:22]

Heh.

There's no consistency across the codebase.  Both of these forms are in wide
use, so we can't really force you to use one over the other.

I always avoid it, because it's pretty much understood, and all the infobar code
and a lot of the views code avoids it.  Less verbiage for the win.  But those
are minor reasons in the grand scheme of things.

Do whatever you find most readable and consistent :)

+  infobars::InfoBarDelegate::InfoBarIdentifier GetIdentifier() const override;
+  int GetIconId() const override;
+  bool ShouldExpire(const NavigationDetails& details) const override;
+  base::string16 GetMessageText() const override;
+  int GetButtons() const override;
+  base::string16 GetLinkText() const override;
+  bool LinkClicked(WindowOpenDisposition disposition) override;
+
+  PreviewsInfoBarType infobar_type_;
+
+  DISALLOW_COPY_AND_ASSIGN(PreviewsInfoBarDelegate);
+};
+
+#endif  // CHROME_BROWSER_PREVIEWS_PREVIEWS_INFOBAR_DELEGATE_H_