Chromium Code Reviews

Issue 22502006: MIPS: Patch to enhance the source code line information for profiler. (Closed)

Created:
7 years, 4 months ago by palfia
Modified:
7 years, 4 months ago
Reviewers:
kisg, Paul Lind, kilvadyb, chunyang.dai, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Patch to enhance the source code line information for profiler. Port r16114 (2d1bf399) Original commit message: This patch is to enhance the source code line information for profiler. For the Hydrogen compilation, most of the source code line information is not copied from the HInstruction the to corresponding LInstruction. This patch defines one PositionBits field for LInstruction and copies the sorce code position value from the HInstruction. When Generating the native code, we use RecordPosition(..) function to write LInstruction's position value to position recorder. BUG= Committed: https://code.google.com/p/v8/source/detail?r=16118

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+45 lines, -10 lines)
M src/mips/lithium-codegen-mips.h View 3 chunks +5 lines, -1 line 0 comments
M src/mips/lithium-codegen-mips.cc View 3 chunks +14 lines, -0 lines 0 comments
M src/mips/lithium-mips.h View 3 chunks +25 lines, -9 lines 0 comments
M src/mips/lithium-mips.cc View 1 chunk +1 line, -0 lines 0 comments

Messages

Total messages: 3 (0 generated)
palfia
PTAL.
7 years, 4 months ago (2013-08-08 18:00:53 UTC) #1
Paul Lind
lgtm
7 years, 4 months ago (2013-08-08 18:30:59 UTC) #2
palfia
7 years, 4 months ago (2013-08-08 18:36:33 UTC) #3
Message was sent while issue was closed.
Committed manually as r16118 (presubmit successful).

Powered by Google App Engine