pkg/compiler/lib/src/universe/universe.dart - Issue 2250193002: Move definition of Feature next to definitions of WorldImpact and Use

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/universe/universe.dart

Issue 2250193002: Move definition of Feature next to definitions of WorldImpact and Use (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/universe/feature.dart ('K') | « pkg/compiler/lib/src/universe/feature.dart ('k') | pkg/compiler/lib/src/universe/use.dart » ('j') | pkg/compiler/lib/src/universe/world_impact.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/universe/universe.dart

diff --git a/pkg/compiler/lib/src/universe/universe.dart b/pkg/compiler/lib/src/universe/universe.dart

index e2bba0148ad3203df0a2d69040e23dd7afe8dd4c..cb574bb95bc1e63a40c944025f9d4ea6a90f156a 100644

--- a/pkg/compiler/lib/src/universe/universe.dart

+++ b/pkg/compiler/lib/src/universe/universe.dart

@@ -102,6 +102,11 @@ abstract class SelectorConstraintsStrategy {

UniverseSelectorConstraints createSelectorConstraints(Selector selector);

}

+/// The [Universe] is an auxiliary class used in the process of computing the

+/// [ClassWorld]. The concepts here and in [ClassWorld] are very similar -- in

+/// the same way that the "universe expands" you can think of this as a mutable

+/// world that is expanding as we visit and discover parts of the program.

+/// TODO(sigmund): rename to "growing/expanding/mutable world"?

class Universe {

/// The set of all directly instantiated classes, that is, classes with a

/// generative constructor that has been called directly and not only through