Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2250193002: Move definition of Feature next to definitions of WorldImpact and Use (Closed)

Created:
4 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move definition of Feature next to definitions of WorldImpact and Use BUG= R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/4a7ae6f340ff984b764856cdf52cc3cbc8ef48ad

Patch Set 1 #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -140 lines) Patch
A pkg/compiler/lib/src/code_organization.md View 1 chunk +26 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/common/resolution.dart View 3 chunks +2 lines, -127 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/impact_serialization.dart View 1 chunk +1 line, -0 lines 0 comments Download
A pkg/compiler/lib/src/universe/feature.dart View 1 chunk +138 lines, -0 lines 1 comment Download
M pkg/compiler/lib/src/universe/universe.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/universe/use.dart View 1 chunk +12 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_impact.dart View 1 chunk +11 lines, -0 lines 6 comments Download
M pkg/compiler/lib/src/world.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 7 (3 generated)
Siggi Cherem (dart-lang)
https://codereview.chromium.org/2250193002/diff/20001/pkg/compiler/lib/src/universe/feature.dart File pkg/compiler/lib/src/universe/feature.dart (right): https://codereview.chromium.org/2250193002/diff/20001/pkg/compiler/lib/src/universe/feature.dart#newcode13 pkg/compiler/lib/src/universe/feature.dart:13: /// A language feature that may be seen in ...
4 years, 4 months ago (2016-08-16 18:21:51 UTC) #3
Harry Terkelsen
lgtm https://codereview.chromium.org/2250193002/diff/20001/pkg/compiler/lib/src/universe/world_impact.dart File pkg/compiler/lib/src/universe/world_impact.dart (right): https://codereview.chromium.org/2250193002/diff/20001/pkg/compiler/lib/src/universe/world_impact.dart#newcode11 pkg/compiler/lib/src/universe/world_impact.dart:11: /// Describes of how an element (e.g. a ...
4 years, 4 months ago (2016-08-16 19:36:15 UTC) #4
Siggi Cherem (dart-lang)
thanks https://codereview.chromium.org/2250193002/diff/20001/pkg/compiler/lib/src/universe/world_impact.dart File pkg/compiler/lib/src/universe/world_impact.dart (right): https://codereview.chromium.org/2250193002/diff/20001/pkg/compiler/lib/src/universe/world_impact.dart#newcode11 pkg/compiler/lib/src/universe/world_impact.dart:11: /// Describes of how an element (e.g. a ...
4 years, 4 months ago (2016-08-16 19:43:30 UTC) #5
Siggi Cherem (dart-lang)
4 years, 4 months ago (2016-08-16 19:44:16 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) manually as
4a7ae6f340ff984b764856cdf52cc3cbc8ef48ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698