Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1784)

Unified Diff: chrome/browser/extensions/api/tabs/tabs_test.cc

Issue 2250183002: New Public IdFromWebContents method on TabManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: implemented suggestion Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/memory/tab_manager.h » ('j') | chrome/browser/memory/tab_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/tabs/tabs_test.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs_test.cc b/chrome/browser/extensions/api/tabs/tabs_test.cc
index 6927d6f7b4b71a887347a91a4b8dc18191f60d5e..eb4cc8b83df02c7b419c590bb22dc0b8c98edff0 100644
--- a/chrome/browser/extensions/api/tabs/tabs_test.cc
+++ b/chrome/browser/extensions/api/tabs/tabs_test.cc
@@ -1360,8 +1360,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, DiscardedProperty) {
EXPECT_FALSE(tab_object_a->discarded);
// Discards one tab.
- EXPECT_TRUE(
- tab_manager->DiscardTabById(reinterpret_cast<int64_t>(web_contents_a)));
+ EXPECT_TRUE(tab_manager->DiscardTabByExtension(web_contents_a));
web_contents_a = tab_strip_model->GetWebContentsAt(1);
// Make sure the property is changed accordingly after discarding the tab.
@@ -1394,8 +1393,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, DiscardedProperty) {
}
// Discards another created tab.
- EXPECT_TRUE(
- tab_manager->DiscardTabById(reinterpret_cast<int64_t>(web_contents_b)));
+ EXPECT_TRUE(tab_manager->DiscardTabByExtension(web_contents_b));
// Get non-discarded tabs after discarding two created tabs.
{
« no previous file with comments | « no previous file | chrome/browser/memory/tab_manager.h » ('j') | chrome/browser/memory/tab_manager.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698