Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1059)

Unified Diff: chrome/browser/safe_browsing/permission_reporter_browsertest.cc

Issue 2250163003: Permission Action Reporting: Fix flaky Browsertest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/permission_reporter_browsertest.cc
diff --git a/chrome/browser/safe_browsing/permission_reporter_browsertest.cc b/chrome/browser/safe_browsing/permission_reporter_browsertest.cc
index 0241e1e7fa5551602614e50b01256ef16b3ccba5..6fb8ef5aa12029b10be3c526b70a7aa6382ca672 100644
--- a/chrome/browser/safe_browsing/permission_reporter_browsertest.cc
+++ b/chrome/browser/safe_browsing/permission_reporter_browsertest.cc
@@ -100,7 +100,7 @@ class PermissionReporterBrowserTest : public InProcessBrowserTest {
// Test that permission action report will be sent if the user is opted into it.
IN_PROC_BROWSER_TEST_F(PermissionReporterBrowserTest,
- DISABLED_PermissionActionReporting) {
+ PermissionActionReporting) {
ASSERT_TRUE(embedded_test_server()->Start());
ui_test_utils::NavigateToURLBlockUntilNavigationsComplete(
@@ -113,6 +113,9 @@ IN_PROC_BROWSER_TEST_F(PermissionReporterBrowserTest,
AcceptBubble();
EXPECT_FALSE(prompt_factory()->is_visible());
+
+ // We need to wait for the report to be sent on the IO thread.
+ mock_report_sender()->WaitForReportSet();
EXPECT_EQ(1, mock_report_sender()->GetAndResetNumberOfReportsSent());
PermissionReport permission_report;

Powered by Google App Engine
This is Rietveld 408576698