Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2250163003: Permission Action Reporting: Fix flaky Browsertest (Closed)

Created:
4 years, 4 months ago by kcarattini
Modified:
4 years, 3 months ago
CC:
chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Permission Action Reporting: Fix flaky Browsertest This is my attempt to fix the flakiness of this browsertest by having the UI thread wait for the report to be sent on the IO thread. BUG=613883, 638316 Committed: https://crrev.com/7476914d264aac8ff5d809d342a6f114b8f7f8dc Cr-Commit-Position: refs/heads/master@{#414252}

Patch Set 1 #

Total comments: 7

Patch Set 2 : Address Comments #

Patch Set 3 : Rebase #

Patch Set 4 : Fix unittest #

Patch Set 5 : uncomment sync check #

Patch Set 6 : Rebase #

Patch Set 7 : remove extra expect #

Patch Set 8 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -6 lines) Patch
M chrome/browser/safe_browsing/mock_permission_report_sender.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/mock_permission_report_sender.cc View 1 2 3 1 chunk +31 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/permission_reporter_browsertest.cc View 1 2 3 4 5 6 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Sam McNally
https://codereview.chromium.org/2250163003/diff/1/chrome/browser/safe_browsing/mock_permission_report_sender.cc File chrome/browser/safe_browsing/mock_permission_report_sender.cc (right): https://codereview.chromium.org/2250163003/diff/1/chrome/browser/safe_browsing/mock_permission_report_sender.cc#newcode13 chrome/browser/safe_browsing/mock_permission_report_sender.cc:13: DCHECK(thread_checker_.CalledOnValidThread()); Using a ThreadChecker in a class that's shared ...
4 years, 4 months ago (2016-08-17 07:52:38 UTC) #2
kcarattini
https://codereview.chromium.org/2250163003/diff/1/chrome/browser/safe_browsing/mock_permission_report_sender.cc File chrome/browser/safe_browsing/mock_permission_report_sender.cc (right): https://codereview.chromium.org/2250163003/diff/1/chrome/browser/safe_browsing/mock_permission_report_sender.cc#newcode13 chrome/browser/safe_browsing/mock_permission_report_sender.cc:13: DCHECK(thread_checker_.CalledOnValidThread()); On 2016/08/17 07:52:38, Sam McNally wrote: > Using ...
4 years, 4 months ago (2016-08-19 03:59:46 UTC) #3
kcarattini
https://codereview.chromium.org/2250163003/diff/1/chrome/browser/safe_browsing/mock_permission_report_sender.cc File chrome/browser/safe_browsing/mock_permission_report_sender.cc (right): https://codereview.chromium.org/2250163003/diff/1/chrome/browser/safe_browsing/mock_permission_report_sender.cc#newcode37 chrome/browser/safe_browsing/mock_permission_report_sender.cc:37: report_set_ = false; On 2016/08/19 03:59:46, kcarattini wrote: > ...
4 years, 4 months ago (2016-08-22 05:09:05 UTC) #4
kcarattini
Nathan: I am still seeing this warning (which has been there since the test was ...
4 years, 4 months ago (2016-08-23 03:00:27 UTC) #7
Nathan Parker
lgtm I"m no expert the the lifetime management of URLRequestContextGetters, but I know Varun has ...
4 years, 4 months ago (2016-08-24 05:13:34 UTC) #9
vakh (use Gerrit instead)
On 2016/08/24 05:13:34, Nathan Parker wrote: > lgtm > > I"m no expert the the ...
4 years, 4 months ago (2016-08-24 19:15:03 UTC) #10
kcarattini
On 2016/08/24 19:15:03, vakh wrote: > On 2016/08/24 05:13:34, Nathan Parker wrote: > > lgtm ...
4 years, 4 months ago (2016-08-25 00:38:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250163003/140001
4 years, 4 months ago (2016-08-25 00:41:02 UTC) #14
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 3 months ago (2016-08-25 02:12:53 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 02:16:16 UTC) #18
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/7476914d264aac8ff5d809d342a6f114b8f7f8dc
Cr-Commit-Position: refs/heads/master@{#414252}

Powered by Google App Engine
This is Rietveld 408576698