Rename async to linearized when parsing

Rename async to linearized when parsing

The parser and document refer to async loading and parsing. The code isn't
actually async but loading a linearized PDF. This Cl renames the methods to
clarify what the code is doing.

The LoadDoc() and LoadLinearizedDoc() methods have been refactored to share
a common LoadDocInternal() method.

Committed: https://pdfium.googlesource.com/pdfium/+/f85e7e2ea29179dfe4ddc25ab410f8898391999c

[dsinclair, 2016-08-16 17:35:53]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 17:35:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-08-16 17:36:21]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, weili@chromium.org

[dsinclair, 2016-08-16 17:36:22]

PTAL.

[commit-bot: I haz the power, 2016-08-16 17:48:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 17:48:08]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-08-16 18:01:40]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2016-08-16 18:08:02]

LGTM with nits, be sure to rebase past my CL first.

https://codereview.chromium.org/2250163002/diff/20001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/cpdf_document.cpp (right):

https://codereview.chromium.org/2250163002/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_document.cpp:521: 
nit: blank line not needed here.

https://codereview.chromium.org/2250163002/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_document.cpp:527: 
nit: blank line not needed here (but the one at 529)

https://codereview.chromium.org/2250163002/diff/20001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/include/cpdf_document.h (right):

https://codereview.chromium.org/2250163002/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/include/cpdf_document.h:87: void
LoadLinearizedDoc(CPDF_Dictionary* pLinearized);
nit: pLinearized also should get renamed, sounds too much like a bool value,
instead of what it actually is.  pLinearizationDictionary is too long.  Is there
a term in the spec we can use?

[dsinclair, 2016-08-16 18:28:18]

https://codereview.chromium.org/2250163002/diff/20001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/cpdf_document.cpp (right):

https://codereview.chromium.org/2250163002/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_document.cpp:521: 
On 2016/08/16 18:08:01, Tom Sepez wrote:
> nit: blank line not needed here.

Done.

https://codereview.chromium.org/2250163002/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_document.cpp:527: 
On 2016/08/16 18:08:01, Tom Sepez wrote:
> nit: blank line not needed here (but the one at 529)

Done.

https://codereview.chromium.org/2250163002/diff/20001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/include/cpdf_document.h (right):

https://codereview.chromium.org/2250163002/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/include/cpdf_document.h:87: void
LoadLinearizedDoc(CPDF_Dictionary* pLinearized);
On 2016/08/16 18:08:01, Tom Sepez wrote:
> nit: pLinearized also should get renamed, sounds too much like a bool value,
> instead of what it actually is.  pLinearizationDictionary is too long.  Is
there
> a term in the spec we can use?

Done.

[dsinclair, 2016-08-16 18:28:21]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-08-16 18:28:21]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2250163002/#ps40001
(title: "review cleanups")

[commit-bot: I haz the power, 2016-08-16 18:28:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 18:43:27]

Description was changed from

==========
Rename async to linearized when parsing

The parser and document refer to async loading and parsing. The code isn't
actually async but loading a linearized PDF. This Cl renames the methods to
clarify what the code is doing.

The LoadDoc() and LoadLinearizedDoc() methods have been refactored to share
a common LoadDocInternal() method.
==========

to

==========
Rename async to linearized when parsing

The parser and document refer to async loading and parsing. The code isn't
actually async but loading a linearized PDF. This Cl renames the methods to
clarify what the code is doing.

The LoadDoc() and LoadLinearizedDoc() methods have been refactored to share
a common LoadDocInternal() method.

Committed:
https://pdfium.googlesource.com/pdfium/+/f85e7e2ea29179dfe4ddc25ab410f8898391...
==========

[commit-bot: I haz the power, 2016-08-16 18:43:28]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/f85e7e2ea29179dfe4ddc25ab410f8898391...