No hang when inserting a list over uneditable element in contenteditable

No hang when inserting a list over uneditable element in contenteditable

While firstEditablePositionAfterPositionInRootAlgorithm() is running,
we can get the next editable paragraph under the highest editable
node by skipping non-editable paragraph.

However, if an editable paragraph has a non-editable child, the next
paragraph can be the same editable paragraph that is the parent of the
non-editable child. In this case, we can't get the next editable
paragraph in InsertListCommand::doApply's while loop. As a result,
the while loop can't break, which makes the tab hang.

Here is the example:
<div contenteditable="true">
  <p>line1<button contenteditable="false">hello</button></p>
  <p>line2</p>
</div>

This CL allows to get the next editable paragraph by considering the
non-editable child element.

BUG=571420
TEST=editing/selection/insert-list-over-uneditable-in-contenteditable.html

Committed: https://crrev.com/f15d4cc339737df653274e39726ae0d14d409b18
Cr-Commit-Position: refs/heads/master@{#412925}

[joone, 2016-08-18 06:52:25]

The CQ bit was checked by joone.hur@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 06:52:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joone, 2016-08-18 07:12:28]

joone.hur@intel.com changed reviewers:
+ yosin@chromium.org

[joone, 2016-08-18 07:12:29]

Hi yosin@ please review this CL.

[commit-bot: I haz the power, 2016-08-18 08:17:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 08:17:49]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-08-18 08:45:26]

lgtm w/ small nits

Wonderful!

https://codereview.chromium.org/2250133004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/editing/selection/insert-list-over-uneditable-in-contenteditable.html
(right):

https://codereview.chromium.org/2250133004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/selection/insert-list-over-uneditable-in-contenteditable.html:6:

nit: we don't need to have an extra blank line.

https://codereview.chromium.org/2250133004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/selection/insert-list-over-uneditable-in-contenteditable.html:11:

nit: we don't need to have an extra blank line.

[joone, 2016-08-18 18:19:20]

Description was changed from

==========
No hang when inserting a list over uneditable element in contenteditable

While firstEditablePositionAfterPositionInRootAlgorithm() is running,
we can get the next editable paragraph under the highest editable
node by skipping non-editable paragraph.

However, if an editable paragraph has a non-editable child, the next
paragraph can be the same editable paragraph that is the parent of the
non-editable child. In this case, we can't get the next editable
paragraph in InsertListCommand::doApply's while loop and can't break
the while loop.

Here is the example:
<div contenteditable="true">
  <p>line1<button contenteditable="false">hello</button></p>
  <p>line2</p>
</div>

This CL allows to get the next editable paragraph by considering the
non-editable child element.

BUG=571420
TEST=editing/selection/insert-list-over-uneditable-in-contenteditable.html
==========

to

==========
No hang when inserting a list over uneditable element in contenteditable

While firstEditablePositionAfterPositionInRootAlgorithm() is running,
we can get the next editable paragraph under the highest editable
node by skipping non-editable paragraph.

However, if an editable paragraph has a non-editable child, the next
paragraph can be the same editable paragraph that is the parent of the
non-editable child. In this case, we can't get the next editable
paragraph in InsertListCommand::doApply's while loop. As a result,
the while loop can't break, which makes the tab hang.

Here is the example:
<div contenteditable="true">
  <p>line1<button contenteditable="false">hello</button></p>
  <p>line2</p>
</div>

This CL allows to get the next editable paragraph by considering the
non-editable child element.

BUG=571420
TEST=editing/selection/insert-list-over-uneditable-in-contenteditable.html
==========

[joone, 2016-08-18 18:21:28]

The CQ bit was checked by joone.hur@intel.com

[joone, 2016-08-18 18:21:29]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2250133004/#ps20001
(title: "Remove extra blanks in the test case")

[commit-bot: I haz the power, 2016-08-18 18:21:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joone, 2016-08-18 18:22:05]

Thanks for review!

https://codereview.chromium.org/2250133004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/editing/selection/insert-list-over-uneditable-in-contenteditable.html
(right):

https://codereview.chromium.org/2250133004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/selection/insert-list-over-uneditable-in-contenteditable.html:6:

On 2016/08/18 08:45:26, Yosi_UTC9 wrote:
> nit: we don't need to have an extra blank line.

Done.

https://codereview.chromium.org/2250133004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/selection/insert-list-over-uneditable-in-contenteditable.html:11:

On 2016/08/18 08:45:26, Yosi_UTC9 wrote:
> nit: we don't need to have an extra blank line.

Done.

[commit-bot: I haz the power, 2016-08-18 20:28:35]

Description was changed from

==========
No hang when inserting a list over uneditable element in contenteditable

While firstEditablePositionAfterPositionInRootAlgorithm() is running,
we can get the next editable paragraph under the highest editable
node by skipping non-editable paragraph.

However, if an editable paragraph has a non-editable child, the next
paragraph can be the same editable paragraph that is the parent of the
non-editable child. In this case, we can't get the next editable
paragraph in InsertListCommand::doApply's while loop. As a result,
the while loop can't break, which makes the tab hang.

Here is the example:
<div contenteditable="true">
  <p>line1<button contenteditable="false">hello</button></p>
  <p>line2</p>
</div>

This CL allows to get the next editable paragraph by considering the
non-editable child element.

BUG=571420
TEST=editing/selection/insert-list-over-uneditable-in-contenteditable.html
==========

to

==========
No hang when inserting a list over uneditable element in contenteditable

While firstEditablePositionAfterPositionInRootAlgorithm() is running,
we can get the next editable paragraph under the highest editable
node by skipping non-editable paragraph.

However, if an editable paragraph has a non-editable child, the next
paragraph can be the same editable paragraph that is the parent of the
non-editable child. In this case, we can't get the next editable
paragraph in InsertListCommand::doApply's while loop. As a result,
the while loop can't break, which makes the tab hang.

Here is the example:
<div contenteditable="true">
  <p>line1<button contenteditable="false">hello</button></p>
  <p>line2</p>
</div>

This CL allows to get the next editable paragraph by considering the
non-editable child element.

BUG=571420
TEST=editing/selection/insert-list-over-uneditable-in-contenteditable.html
==========

[commit-bot: I haz the power, 2016-08-18 20:28:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-18 20:29:54]

Description was changed from

==========
No hang when inserting a list over uneditable element in contenteditable

While firstEditablePositionAfterPositionInRootAlgorithm() is running,
we can get the next editable paragraph under the highest editable
node by skipping non-editable paragraph.

However, if an editable paragraph has a non-editable child, the next
paragraph can be the same editable paragraph that is the parent of the
non-editable child. In this case, we can't get the next editable
paragraph in InsertListCommand::doApply's while loop. As a result,
the while loop can't break, which makes the tab hang.

Here is the example:
<div contenteditable="true">
  <p>line1<button contenteditable="false">hello</button></p>
  <p>line2</p>
</div>

This CL allows to get the next editable paragraph by considering the
non-editable child element.

BUG=571420
TEST=editing/selection/insert-list-over-uneditable-in-contenteditable.html
==========

to

==========
No hang when inserting a list over uneditable element in contenteditable

While firstEditablePositionAfterPositionInRootAlgorithm() is running,
we can get the next editable paragraph under the highest editable
node by skipping non-editable paragraph.

However, if an editable paragraph has a non-editable child, the next
paragraph can be the same editable paragraph that is the parent of the
non-editable child. In this case, we can't get the next editable
paragraph in InsertListCommand::doApply's while loop. As a result,
the while loop can't break, which makes the tab hang.

Here is the example:
<div contenteditable="true">
  <p>line1<button contenteditable="false">hello</button></p>
  <p>line2</p>
</div>

This CL allows to get the next editable paragraph by considering the
non-editable child element.

BUG=571420
TEST=editing/selection/insert-list-over-uneditable-in-contenteditable.html

Committed: https://crrev.com/f15d4cc339737df653274e39726ae0d14d409b18
Cr-Commit-Position: refs/heads/master@{#412925}
==========

[commit-bot: I haz the power, 2016-08-18 20:29:55]

Patchset 2 (id:??) landed as
https://crrev.com/f15d4cc339737df653274e39726ae0d14d409b18
Cr-Commit-Position: refs/heads/master@{#412925}