third_party/WebKit/Source/modules/compositorworker/CompositorWorker.idl - Issue 2250063002: binding: Adds a check that ActiveScriptWrappable specifies [ActiveScriptWrappable].

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/compositorworker/CompositorWorker.idl

Issue 2250063002: binding: Adds a check that ActiveScriptWrappable specifies [ActiveScriptWrappable]. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/bindings/templates/interface_base.cpp ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8Uint8ClampedArray.cpp ('k') | third_party/WebKit/Source/modules/fetch/Request.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 [	5 [

	6 ActiveScriptWrappable,
	haraken 2016/08/16 11:38:02 How was CompositorWorker working without having [A How was CompositorWorker working without having [ActiveScriptWrappable]? Or was it broken? Yuki 2016/08/16 12:04:39 I have no idea. Probably we were just lucky, or i Show quoted text On 2016/08/16 11:38:02, haraken wrote: > > How was CompositorWorker working without having [ActiveScriptWrappable]? Or was > it broken? I have no idea. Probably we were just lucky, or it may have been broken. a) CompositorWorker itself does not define hasPendingActivity(), so it's possible that CompositorWorker itself does not care much about pending activities. b) CompositorWorker inherits from InProcessWorkerBase, which defines hasPendingActivity(). I don't have deep knowledge about CompositorWorker, so I can't say a lot.
6 DependentLifetime,	7 DependentLifetime,

7 Constructor(DOMString scriptUrl),	8 Constructor(DOMString scriptUrl),

8 ConstructorCallWith=ExecutionContext,	9 ConstructorCallWith=ExecutionContext,

9 RaisesException=Constructor,	10 RaisesException=Constructor,

10 RuntimeEnabled=CompositorWorker,	11 RuntimeEnabled=CompositorWorker,

11 ] interface CompositorWorker : EventTarget {	12 ] interface CompositorWorker : EventTarget {

12 attribute EventHandler onmessage;	13 attribute EventHandler onmessage;

13 [PostMessage, RaisesException] void postMessage(SerializedScriptValue messag e, optional sequence<Transferable> transfer);	14 [PostMessage, RaisesException] void postMessage(SerializedScriptValue messag e, optional sequence<Transferable> transfer);

14 void terminate();	15 void terminate();

15 };	16 };

16	17

17 CompositorWorker implements AbstractWorker;	18 CompositorWorker implements AbstractWorker;

OLD	NEW