binding: Adds a check that ActiveScriptWrappable specifies [ActiveScriptWrappable].

third_party/WebKit/Source/bindings/templates/interface_base.cpp

 {% include 'copyright_block.txt' %}
 #include "{{v8_class_or_partial}}.h"
 
 {% for filename in cpp_includes if filename != '%s.h' % cpp_class_or_partial %}
 #include "{{filename}}"
 {% endfor %}
 
 namespace blink {
 {% set to_active_scriptwrappable = '%s::toActiveScriptWrappable' % v8_class
                                    if active_scriptwrappable else '0' %}
@@ skipping 10 matching lines @@
 // Suppress warning: global constructors, because struct WrapperTypeInfo is trivial
 // and does not depend on another global objects.
 #if defined(COMPONENT_BUILD) && defined(WIN32) && COMPILER(CLANG)
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wglobal-constructors"
 #endif
 {{wrapper_type_info_const}}WrapperTypeInfo {{v8_class}}::wrapperTypeInfo = { gin::kEmbedderBlink, {{dom_template}}, {{v8_class}}::trace, {{v8_class}}::traceWrappers, {{to_active_scriptwrappable}}, {{visit_dom_wrapper}}, {{v8_class}}::preparePrototypeAndInterfaceObject,{% if has_conditional_attributes %} {{v8_class}}::installConditionallyEnabledProperties{% else %} nullptr{% endif %}, "{{interface_name}}", {{parent_wrapper_type_info}}, WrapperTypeInfo::{{wrapper_type_prototype}}, WrapperTypeInfo::{{wrapper_class_id}}, WrapperTypeInfo::{{event_target_inheritance}}, WrapperTypeInfo::{{lifetime}} };
 #if defined(COMPONENT_BUILD) && defined(WIN32) && COMPILER(CLANG)
 #pragma clang diagnostic pop
 #endif
+{% if not is_typed_array_type %}
 
 // This static member must be declared by DEFINE_WRAPPERTYPEINFO in {{cpp_class}}.h.
 // For details, see the comment of DEFINE_WRAPPERTYPEINFO in
 // bindings/core/v8/ScriptWrappable.h.
-{% if not is_typed_array_type %}
 const WrapperTypeInfo& {{cpp_class}}::s_wrapperTypeInfo = {{v8_class}}::wrapperTypeInfo;
 {% endif %}
+{% if not active_scriptwrappable %}
 
+static_assert(
+    !std::is_base_of<ActiveScriptWrappable, {{cpp_class}}>::value,
+    "{{cpp_class}} inherits from ActiveScriptWrappable, but does not specify "
+    "[ActiveScriptWrappable] extended attribute in the IDL file.  "
+    "Be consistent.");

[peria, 2016/08/16 07:24:43]

Don't we need to care the inverted situation?
I mean that an IDL class has [ActiveScriptWrappable] attribute, while the C++
class does not inherit from ActiveScriptWrappable.

[Yuki, 2016/08/16 08:43:27]

In that case, a compile error is already happening because T* is not convertible
to ActiveScriptWrappable*.

[Yuki, 2016/08/16 08:44:36]

Just FYI, it's the same that T* does not inherit from ScriptWrappable, or
EventTarget.

 {% endif %}
+
+{% endif %}{# not is_partial #}
 {% if not is_array_buffer_or_view %}
 namespace {{cpp_class_or_partial}}V8Internal {
 {% if has_partial_interface %}
 {% for method in methods if method.overloads and method.overloads.has_partial_overloads %}
 static void (*{{method.name}}MethodForPartialInterface)(const v8::FunctionCallbackInfo<v8::Value>&) = 0;
 {% endfor %}
 {% endif %}
 
 {# Constants #}
 {% from 'constants.cpp' import constant_getter_callback
@@ skipping 380 matching lines @@
 {{method_implemented_in_private_script(method)}}
 {% endfor %}
 {% for attribute in attributes if attribute.is_implemented_in_private_script %}
 {{attribute_getter_implemented_in_private_script(attribute)}}
 {% if attribute.has_setter %}
 {{attribute_setter_implemented_in_private_script(attribute)}}
 {% endif %}
 {% endfor %}
 {% block partial_interface %}{% endblock %}
 } // namespace blink