Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2250053005: Make Buildbot masters send ts_mon metrics, and add standard HTTP server metrics. (Closed)

Created:
4 years, 4 months ago by dsansome
Modified:
4 years, 4 months ago
Reviewers:
Sergey Berezin
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, agable, ghost stip (do not use)
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Make Buildbot masters send ts_mon metrics, and add standard HTTP server metrics. This is a re-land of https://codereview.chromium.org/2103073002/ - it should work now we've added the necessary dependencies to slave.DEPS and master.DEPS. BUG=620610 TBR=sergeyberezin Committed: https://chromium.googlesource.com/chromium/tools/build/+/0ebf9a02f0d7c6312c57e6bac9ebc8193f42036b

Patch Set 1 #

Patch Set 2 : Fix a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -5 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M masters/buildbot.tac View 1 1 chunk +24 lines, -1 line 0 comments Download
M scripts/master/master_utils.py View 2 chunks +3 lines, -1 line 0 comments Download
A scripts/master/monitoring_status_receiver.py View 1 chunk +41 lines, -0 lines 0 comments Download
M third_party/buildbot_8_4p1/buildbot/status/web/baseweb.py View 3 chunks +32 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (4 generated)
dsansome
4 years, 4 months ago (2016-08-17 04:12:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250053005/20001
4 years, 4 months ago (2016-08-17 04:12:41 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/tools/build/+/0ebf9a02f0d7c6312c57e6bac9ebc8193f42036b
4 years, 4 months ago (2016-08-17 04:17:01 UTC) #7
Paweł Hajdan Jr.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2254713002/ by phajdan.jr@chromium.org. ...
4 years, 4 months ago (2016-08-17 08:26:01 UTC) #8
dsansome
On 2016/08/17 08:26:01, Paweł Hajdan Jr. wrote: > A revert of this CL (patchset #2 ...
4 years, 4 months ago (2016-08-17 08:47:58 UTC) #9
agable
Wait we still have .DEPS.git files in those repos? The regular DEPS files should be ...
4 years, 4 months ago (2016-08-17 17:16:44 UTC) #10
Sergey Berezin
lgtm - just to mark this CL as "reviewed". Obviously, it didn't work as is... ...
4 years, 4 months ago (2016-08-17 20:22:32 UTC) #11
dsansome
4 years, 4 months ago (2016-08-18 02:03:54 UTC) #12
Message was sent while issue was closed.
> Wait we still have .DEPS.git files in those repos? The regular DEPS files
> should be replaced with the content of the current .DEPS.git, and the
> .DEPS.git should be deleted.

I've sent you:
https://chromereviews.googleplex.com/492857013/
https://chromereviews.googleplex.com/486447013/
https://chromereviews.googleplex.com/494807013/

> But maybe with the updates in the internal repo it would work as is.

I've updated internal.DEPS and I'm going to give this another try today.

Powered by Google App Engine
This is Rietveld 408576698