Make Buildbot masters send ts_mon metrics, and add standard HTTP server metrics.

Make Buildbot masters send ts_mon metrics, and add standard HTTP server metrics.

This is a re-land of https://codereview.chromium.org/2103073002/ - it should
work now we've added the necessary dependencies to slave.DEPS and master.DEPS.

BUG=620610
TBR=sergeyberezin

Committed: https://chromium.googlesource.com/chromium/tools/build/+/0ebf9a02f0d7c6312c57e6bac9ebc8193f42036b

[dsansome, 2016-08-17 04:12:07]

Description was changed from

==========
Make Buildbot masters send ts_mon metrics, and add standard HTTP server metrics.

This is a re-land of https://codereview.chromium.org/2103073002/ - it should
work now we've added the necessary dependencies to slave.DEPS and master.DEPS.

BUG=620610
==========

to

==========
Make Buildbot masters send ts_mon metrics, and add standard HTTP server metrics.

This is a re-land of https://codereview.chromium.org/2103073002/ - it should
work now we've added the necessary dependencies to slave.DEPS and master.DEPS.

BUG=620610
TBR=sergeyberezin
==========

[dsansome, 2016-08-17 04:12:21]

dsansome@chromium.org changed reviewers:
+ sergeyberezin@chromium.org

[dsansome, 2016-08-17 04:12:29]

The CQ bit was checked by dsansome@chromium.org

[commit-bot: I haz the power, 2016-08-17 04:12:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 04:17:00]

Description was changed from

==========
Make Buildbot masters send ts_mon metrics, and add standard HTTP server metrics.

This is a re-land of https://codereview.chromium.org/2103073002/ - it should
work now we've added the necessary dependencies to slave.DEPS and master.DEPS.

BUG=620610
TBR=sergeyberezin
==========

to

==========
Make Buildbot masters send ts_mon metrics, and add standard HTTP server metrics.

This is a re-land of https://codereview.chromium.org/2103073002/ - it should
work now we've added the necessary dependencies to slave.DEPS and master.DEPS.

BUG=620610
TBR=sergeyberezin

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/0ebf9a02f0d7c6312c57...
==========

[commit-bot: I haz the power, 2016-08-17 04:17:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/0ebf9a02f0d7c6312c57...

[Paweł Hajdan Jr., 2016-08-17 08:26:01]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2254713002/ by phajdan.jr@chromium.org.

The reason for reverting is: Still breaks internal bots, e.g.
https://goto.google.com/ggkgw.

[dsansome, 2016-08-17 08:47:58]

On 2016/08/17 08:26:01, Paweł Hajdan Jr. wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/2254713002/ by mailto:phajdan.jr@chromium.org.
> 
> The reason for reverting is: Still breaks internal bots, e.g.
> https://goto.google.com/ggkgw.

Oops thanks for dealing with this.

I guess I need to add these deps to
https://chrome-internal.googlesource.com/chrome/tools/build/internal.DEPS.git...
as well.

[agable, 2016-08-17 17:16:44]

Wait we still have .DEPS.git files in those repos? The regular DEPS files
should be replaced with the content of the current .DEPS.git, and the
.DEPS.git should be deleted.

On Wed, Aug 17, 2016 at 1:48 AM <dsansome@chromium.org> wrote:

> On 2016/08/17 08:26:01, Paweł Hajdan Jr. wrote:
> > A revert of this CL (patchset #2 id:20001) has been created in
> > https://codereview.chromium.org/2254713002/ by mailto:
> phajdan.jr@chromium.org.
>
> >
> > The reason for reverting is: Still breaks internal bots, e.g.
> > https://goto.google.com/ggkgw.
>
> Oops thanks for dealing with this.
>
> I guess I need to add these deps to
>
>
https://chrome-internal.googlesource.com/chrome/tools/build/internal.DEPS.git...
> as well.
>
> https://codereview.chromium.org/2250053005/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Sergey Berezin, 2016-08-17 20:22:32]

lgtm - just to mark this CL as "reviewed". Obviously, it didn't work as is...
But maybe with the updates in the internal repo it would work as is.

[dsansome, 2016-08-18 02:03:54]

> Wait we still have .DEPS.git files in those repos? The regular DEPS files
> should be replaced with the content of the current .DEPS.git, and the
> .DEPS.git should be deleted.

I've sent you:
https://chromereviews.googleplex.com/492857013/
https://chromereviews.googleplex.com/486447013/
https://chromereviews.googleplex.com/494807013/

> But maybe with the updates in the internal repo it would work as is.

I've updated internal.DEPS and I'm going to give this another try today.