components/infobars/core/infobar_delegate.h - Issue 2250053002: Clean up the PermissionInfoBarDelegate hierarchy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/infobars/core/infobar_delegate.h

Issue 2250053002: Clean up the PermissionInfoBarDelegate hierarchy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-infobar-remember-decision

Patch Set: Address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/permissions/permission_infobar_delegate.cc ('K') | « chrome/browser/ui/android/infobars/permission_infobar.cc ('k') | components/infobars/core/infobar_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/infobars/core/infobar_delegate.h

diff --git a/components/infobars/core/infobar_delegate.h b/components/infobars/core/infobar_delegate.h

index ab21469b37cbaed690fc25083cb4b1c865a15691..be340b79987f9c2d3c06f3c765b16e03bceefc9a 100644

--- a/components/infobars/core/infobar_delegate.h

+++ b/components/infobars/core/infobar_delegate.h

@@ -14,7 +14,7 @@ class ConfirmInfoBarDelegate;

class HungRendererInfoBarDelegate;

class InsecureContentInfoBarDelegate;

class NativeAppInfoBarDelegate;

-class PermissionInfobarDelegate;

+class PermissionInfoBarDelegate;

class PopupBlockedInfoBarDelegate;

class RegisterProtocolHandlerInfoBarDelegate;

class ScreenCaptureInfoBarDelegate;

@@ -206,7 +206,7 @@ class InfoBarDelegate {

virtual HungRendererInfoBarDelegate* AsHungRendererInfoBarDelegate();

virtual InsecureContentInfoBarDelegate* AsInsecureContentInfoBarDelegate();

virtual NativeAppInfoBarDelegate* AsNativeAppInfoBarDelegate();

- virtual PermissionInfobarDelegate* AsPermissionInfobarDelegate();

+ virtual PermissionInfoBarDelegate* AsPermissionInfoBarDelegate();

virtual PopupBlockedInfoBarDelegate* AsPopupBlockedInfoBarDelegate();

virtual RegisterProtocolHandlerInfoBarDelegate*

AsRegisterProtocolHandlerInfoBarDelegate();