chrome/browser/permissions/permission_util.cc - Issue 2250053002: Clean up the PermissionInfoBarDelegate hierarchy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_util.cc

Issue 2250053002: Clean up the PermissionInfoBarDelegate hierarchy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-infobar-remember-decision

Patch Set: Address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/permissions/permission_infobar_delegate.cc ('K') | « chrome/browser/permissions/permission_util.h ('k') | chrome/browser/ui/android/infobars/permission_infobar.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_util.cc

diff --git a/chrome/browser/permissions/permission_util.cc b/chrome/browser/permissions/permission_util.cc

index 036a156d3d8ff0b11b6e3573450a3172bebc3f73..6ce2f79fc6b9b09f8890160af6ebd6393cbfc3e0 100644

--- a/chrome/browser/permissions/permission_util.cc

+++ b/chrome/browser/permissions/permission_util.cc

@@ -4,9 +4,11 @@

#include "chrome/browser/permissions/permission_util.h"

+#include "base/feature_list.h"

#include "base/logging.h"

#include "chrome/browser/content_settings/host_content_settings_map_factory.h"

#include "chrome/browser/permissions/permission_uma_util.h"

+#include "chrome/common/chrome_features.h"

#include "components/content_settings/core/browser/host_content_settings_map.h"

#include "content/public/browser/permission_type.h"

@@ -76,6 +78,11 @@ bool PermissionUtil::GetPermissionType(ContentSettingsType type,

return true;

}

+bool PermissionUtil::ShouldShowPersistenceToggle() {

+ return base::FeatureList::IsEnabled(

+ features::kDisplayPersistenceToggleInPermissionPrompts);

PermissionUtil::ScopedRevocationReporter::ScopedRevocationReporter(

Profile* profile,

const GURL& primary_url,