chrome/browser/permissions/grouped_permission_infobar_delegate.cc - Issue 2250053002: Clean up the PermissionInfoBarDelegate hierarchy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/grouped_permission_infobar_delegate.cc

Issue 2250053002: Clean up the PermissionInfoBarDelegate hierarchy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-infobar-remember-decision

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/permissions/grouped_permission_infobar_delegate.h ('k') | chrome/browser/permissions/permission_infobar_delegate.h » ('j') | chrome/browser/permissions/permission_infobar_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/grouped_permission_infobar_delegate.cc

diff --git a/chrome/browser/permissions/grouped_permission_infobar_delegate.cc b/chrome/browser/permissions/grouped_permission_infobar_delegate.cc

index 46795c43fa3350fc94c9536e35f385514b60bdf6..181ab6f577aad88b8f9a7d0822c4d4eb62bad525 100644

--- a/chrome/browser/permissions/grouped_permission_infobar_delegate.cc

+++ b/chrome/browser/permissions/grouped_permission_infobar_delegate.cc

@@ -11,7 +11,7 @@

GroupedPermissionInfoBarDelegate::GroupedPermissionInfoBarDelegate(

const GURL& requesting_origin,

const std::vector<ContentSettingsType>& types)

- : requesting_origin_(requesting_origin),

+ : PermissionInfoBarDelegate(requesting_origin),

types_(types),

accept_states_(types_.size(), true) {}

@@ -42,7 +42,7 @@ base::string16 GroupedPermissionInfoBarDelegate::GetButtonLabel(

base::string16 GroupedPermissionInfoBarDelegate::GetMessageText() const {

return l10n_util::GetStringFUTF16(

IDS_PERMISSIONS_BUBBLE_PROMPT,

- url_formatter::FormatUrlForSecurityDisplay(requesting_origin_));

+ url_formatter::FormatUrlForSecurityDisplay(requesting_origin()));

}

int GroupedPermissionInfoBarDelegate::GetPermissionCount() const {