Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2250033002: [Sync] Create //components/sync/device_info. (Closed)

Created:
4 years, 4 months ago by maxbogue
Modified:
4 years, 4 months ago
Reviewers:
jam, skym
CC:
chromium-reviews, extensions-reviews_chromium.org, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, Patrick Dubroy, dbeam+watch-history_chromium.org, pam+watch_chromium.org, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, sync-reviews_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Create //components/sync/device_info. This CL creates a new sync subfolder for all the device_info code. It is still co-dependent on driver/, but since conceptually device_info is its own data type it should get its own folder. BUG=638086 TBR=jam Committed: https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32 Cr-Commit-Position: refs/heads/master@{#412301}

Patch Set 1 #

Patch Set 2 : Fix lint on device info files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -4078 lines) Patch
M chrome/browser/extensions/api/sessions/sessions_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/signed_in_devices/id_mapping_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/app_menu/app_menu_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/browsing_history_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/browser_sync/browser/profile_sync_components_factory_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service.h View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/browser/profile_sync_service.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/history_delete_directives_data_type_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/BUILD.gn View 6 chunks +24 lines, -24 lines 0 comments Download
A + components/sync/device_info/DEPS View 1 chunk +4 lines, -5 lines 0 comments Download
A + components/sync/device_info/device_count_metrics_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync/device_info/device_count_metrics_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/sync/device_info/device_count_metrics_provider_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync/device_info/device_info.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync/device_info/device_info.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/device_info/device_info_data_type_controller.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/sync/device_info/device_info_data_type_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/sync/device_info/device_info_data_type_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/sync/device_info/device_info_service.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + components/sync/device_info/device_info_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/sync/device_info/device_info_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/sync/device_info/device_info_sync_service.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + components/sync/device_info/device_info_sync_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync/device_info/device_info_sync_service_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync/device_info/device_info_tracker.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/sync/device_info/device_info_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync/device_info/device_info_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/device_info/device_info_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/device_info/local_device_info_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync/device_info/local_device_info_provider_impl.h View 1 2 chunks +6 lines, -5 lines 0 comments Download
A + components/sync/device_info/local_device_info_provider_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/device_info/local_device_info_provider_mock.h View 1 2 chunks +6 lines, -5 lines 0 comments Download
A + components/sync/device_info/local_device_info_provider_mock.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/device_info/local_device_info_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/DEPS View 2 chunks +1 line, -1 line 0 comments Download
D components/sync/driver/device_count_metrics_provider.h View 1 chunk +0 lines, -53 lines 0 comments Download
D components/sync/driver/device_count_metrics_provider.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D components/sync/driver/device_count_metrics_provider_unittest.cc View 1 chunk +0 lines, -104 lines 0 comments Download
D components/sync/driver/device_info.h View 1 chunk +0 lines, -101 lines 0 comments Download
D components/sync/driver/device_info.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D components/sync/driver/device_info_data_type_controller.h View 1 chunk +0 lines, -44 lines 0 comments Download
D components/sync/driver/device_info_data_type_controller.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D components/sync/driver/device_info_data_type_controller_unittest.cc View 1 chunk +0 lines, -126 lines 0 comments Download
D components/sync/driver/device_info_service.h View 1 chunk +0 lines, -191 lines 0 comments Download
D components/sync/driver/device_info_service.cc View 1 chunk +0 lines, -538 lines 0 comments Download
D components/sync/driver/device_info_service_unittest.cc View 1 chunk +0 lines, -780 lines 0 comments Download
D components/sync/driver/device_info_sync_service.h View 1 chunk +0 lines, -111 lines 0 comments Download
D components/sync/driver/device_info_sync_service.cc View 1 chunk +0 lines, -335 lines 0 comments Download
D components/sync/driver/device_info_sync_service_unittest.cc View 1 chunk +0 lines, -581 lines 0 comments Download
D components/sync/driver/device_info_tracker.h View 1 chunk +0 lines, -46 lines 0 comments Download
D components/sync/driver/device_info_util.h View 1 chunk +0 lines, -58 lines 0 comments Download
D components/sync/driver/device_info_util.cc View 1 chunk +0 lines, -56 lines 0 comments Download
D components/sync/driver/device_info_util_unittest.cc View 1 chunk +0 lines, -113 lines 0 comments Download
M components/sync/driver/generic_change_processor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/glue/sync_backend_host_core.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D components/sync/driver/local_device_info_provider.h View 1 chunk +0 lines, -64 lines 0 comments Download
D components/sync/driver/local_device_info_provider_impl.h View 1 chunk +0 lines, -64 lines 0 comments Download
D components/sync/driver/local_device_info_provider_impl.cc View 1 chunk +0 lines, -112 lines 0 comments Download
D components/sync/driver/local_device_info_provider_mock.h View 1 chunk +0 lines, -52 lines 0 comments Download
D components/sync/driver/local_device_info_provider_mock.cc View 1 chunk +0 lines, -74 lines 0 comments Download
D components/sync/driver/local_device_info_provider_unittest.cc View 1 chunk +0 lines, -146 lines 0 comments Download
M components/sync/driver/shared_change_processor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/sync_api_component_factory_mock.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_sessions/session_data_type_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_sessions/session_data_type_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_sessions/sessions_sync_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_sessions/sessions_sync_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_metrics_service_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/history/browsing_history_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
maxbogue
Yo Sky, PTAL! I got bored and decided to implement one of my own suggestions ...
4 years, 4 months ago (2016-08-16 04:50:20 UTC) #4
skym
lgtm
4 years, 4 months ago (2016-08-16 16:12:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250033002/20001
4 years, 4 months ago (2016-08-16 18:03:07 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/239043)
4 years, 4 months ago (2016-08-16 18:08:02 UTC) #13
maxbogue
TBR'ing jam@ for everything outside sync.
4 years, 4 months ago (2016-08-16 19:06:04 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250033002/20001
4 years, 4 months ago (2016-08-16 19:06:39 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-16 19:13:38 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 19:16:34 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f1885f7d37ad5848c5d1e0594e77f1e3f5b8fd32
Cr-Commit-Position: refs/heads/master@{#412301}

Powered by Google App Engine
This is Rietveld 408576698