components/proximity_auth/cryptauth/cryptauth_device_manager_unittest.cc - Issue 2250023005: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/proximity_auth/cryptauth/cryptauth_device_manager_unittest.cc

Issue 2250023005: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/proximity_auth/cryptauth/cryptauth_device_manager.cc ('k') | components/proximity_auth/cryptauth/cryptauth_enrollment_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/proximity_auth/cryptauth/cryptauth_device_manager_unittest.cc

diff --git a/components/proximity_auth/cryptauth/cryptauth_device_manager_unittest.cc b/components/proximity_auth/cryptauth/cryptauth_device_manager_unittest.cc

index 77e146443fb3598177980a918671e75b242136bc..d5c71218634bdf0d1054a3e81ea591757fe7ac12 100644

--- a/components/proximity_auth/cryptauth/cryptauth_device_manager_unittest.cc

+++ b/components/proximity_auth/cryptauth/cryptauth_device_manager_unittest.cc

@@ -256,8 +256,9 @@ class ProximityAuthCryptAuthDeviceManagerTest

SyncScheduler::Delegate* delegate =

static_cast<SyncScheduler::Delegate*>(device_manager_.get());

- std::unique_ptr<SyncScheduler::SyncRequest> sync_request = base::WrapUnique(

- new SyncScheduler::SyncRequest(device_manager_->GetSyncScheduler()));

+ std::unique_ptr<SyncScheduler::SyncRequest> sync_request =

+ base::MakeUnique<SyncScheduler::SyncRequest>(

+ device_manager_->GetSyncScheduler());

EXPECT_CALL(*this, OnSyncStartedProxy());

delegate->OnSyncRequested(std::move(sync_request));

@@ -353,8 +354,8 @@ TEST_F(ProximityAuthCryptAuthDeviceManagerTest, InitWithDefaultPrefs) {

TestCryptAuthDeviceManager device_manager(

std::move(clock),

- base::WrapUnique(new MockCryptAuthClientFactory(

- MockCryptAuthClientFactory::MockType::MAKE_STRICT_MOCKS)),

+ base::MakeUnique<MockCryptAuthClientFactory>(

+ MockCryptAuthClientFactory::MockType::MAKE_STRICT_MOCKS),

&gcm_manager_, &pref_service);

EXPECT_CALL(