Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1806)

Issue 2250003002: Revert of Drop third_party/swiftshader/ from .gitignore (Closed)

Created:
4 years, 4 months ago by Peter Kasting
Modified:
4 years, 4 months ago
Reviewers:
capn, stevenjb, sugoi1, foolip
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Drop third_party/swiftshader/ from .gitignore (patchset #1 id:1 of https://codereview.chromium.org/2224093003/ ) Reason for revert: This was re-added to DEPS and is now showing up as untracked again. Original issue's description: > Drop third_party/swiftshader/ from .gitignore > > It's no longer in DEPS, and its precense in .gitignore may be why it's > still left in the checkout causing checklicenses failures. > > BUG=635880 > TBR=stevenjb@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/341fac67de9500a95d8ed16545a9b0e1f859991d TBR=stevenjb@chromium.org,capn@chromium.org,sugoi@chromium.org,foolip@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=635880 Committed: https://crrev.com/924e6f4db66fdeac8f95c9cb04e671281604b9ea Cr-Commit-Position: refs/heads/master@{#412160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Peter Kasting
Created Revert of Drop third_party/swiftshader/ from .gitignore
4 years, 4 months ago (2016-08-16 03:12:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250003002/1
4 years, 4 months ago (2016-08-16 03:12:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 03:53:31 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 03:55:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/924e6f4db66fdeac8f95c9cb04e671281604b9ea
Cr-Commit-Position: refs/heads/master@{#412160}

Powered by Google App Engine
This is Rietveld 408576698