Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2249973002: [wasm] Serialization test using external APIs and contexts (Closed)

Created:
4 years, 4 months ago by Mircea Trofin
Modified:
4 years, 4 months ago
Reviewers:
titzer, bradnelson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Serialization test using external APIs and contexts A test exercising the public APIs for wasm serialization and simulates the serialization scenario - serialize in one isolate, deserialize in another. BUG=v8:5072 Committed: https://crrev.com/0686c414a6c7e2ec26a8a773fd042ca883964596 Cr-Commit-Position: refs/heads/master@{#38644}

Patch Set 1 #

Patch Set 2 : Serialization test using external APIs and contexts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -9 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/wasm/wasm-module.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/wasm/wasm-module.cc View 3 chunks +10 lines, -4 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 1 3 chunks +84 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Mircea Trofin
4 years, 4 months ago (2016-08-16 04:50:30 UTC) #11
titzer
lgtm
4 years, 4 months ago (2016-08-16 07:32:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249973002/20001
4 years, 4 months ago (2016-08-16 08:05:36 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-16 08:07:16 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 08:07:26 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0686c414a6c7e2ec26a8a773fd042ca883964596
Cr-Commit-Position: refs/heads/master@{#38644}

Powered by Google App Engine
This is Rietveld 408576698