Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2249963002: Disabled "BackgroundTest.ActiveOrInactive" due to flakiness (Closed)

Created:
4 years, 4 months ago by sashab
Modified:
4 years, 4 months ago
Reviewers:
aboxhall
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabled "BackgroundTest.ActiveOrInactive" due to flakiness Added the DISABLED_ prefix which usually disables tests. Hopefully this actually disables it, not sure if it works in JS tests. TBR=aboxhall@chromium.org BUG=635032 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ed7d3c4b27646172ae140e15825c82135fdf0e39 Cr-Commit-Position: refs/heads/master@{#412139}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs View 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249963002/1
4 years, 4 months ago (2016-08-16 01:15:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 02:20:37 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 02:22:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed7d3c4b27646172ae140e15825c82135fdf0e39
Cr-Commit-Position: refs/heads/master@{#412139}

Powered by Google App Engine
This is Rietveld 408576698