Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 2249943002: Preprocess icons.html files for <if>s (Closed)

Created:
4 years, 4 months ago by michaelpg
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Preprocess settings/icons.html and cr_elements/icons.html for <if>s BUG=605821 R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e4e61b6bb3a602adecf92d4e0a41804e5997895f Cr-Commit-Position: refs/heads/master@{#412159}

Patch Set 1 #

Patch Set 2 : same for cr_elements #

Patch Set 3 : preprocess #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/resources/settings/settings_resources.grd View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ui/webui/resources/cr_elements_resources.grdp View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
michaelpg
oops
4 years, 4 months ago (2016-08-16 00:47:54 UTC) #2
Dan Beam
can you please use preprocess=true instead if you only need <if>?
4 years, 4 months ago (2016-08-16 00:52:41 UTC) #3
Dan Beam
On 2016/08/16 00:52:41, Dan Beam wrote: > can you please use preprocess=true instead if you ...
4 years, 4 months ago (2016-08-16 00:52:53 UTC) #4
michaelpg
ptal preprocess="true" doesn't seem to work for md_history/history.html -- flattenhtml does, though. maybe because it's ...
4 years, 4 months ago (2016-08-16 00:58:26 UTC) #6
Dan Beam
On 2016/08/16 00:58:26, michaelpg wrote: > ptal > > preprocess="true" doesn't seem to work for ...
4 years, 4 months ago (2016-08-16 01:27:08 UTC) #7
Dan Beam
lgtm
4 years, 4 months ago (2016-08-16 01:27:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249943002/40001
4 years, 4 months ago (2016-08-16 02:58:10 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-16 03:41:11 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 03:43:02 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e4e61b6bb3a602adecf92d4e0a41804e5997895f
Cr-Commit-Position: refs/heads/master@{#412159}

Powered by Google App Engine
This is Rietveld 408576698