chrome/browser/resources/settings/route.js - Issue 2249933002: WebUI cr-dialog: Cancel dialog on any 'popstate' event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/route.js

Issue 2249933002: WebUI cr-dialog: Cancel dialog on any 'popstate' event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ensure we popstate before any route changes. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/route.js

diff --git a/chrome/browser/resources/settings/route.js b/chrome/browser/resources/settings/route.js

index 5d45fd89bb9e4f8374c311bf42869347619ab46c..412e880c39d91298bad954667e3823ad5a76597c 100644

--- a/chrome/browser/resources/settings/route.js

+++ b/chrome/browser/resources/settings/route.js

@@ -334,9 +334,8 @@ cr.define('settings', function() {

}

// History serializes the state, so we don't push the actual route object.

- var previousRoutePath = currentRoute_.path;

+ window.history.pushState(currentRoute_.path, '', url);

setCurrentRoute(route, params);

- window.history.pushState(previousRoutePath, '', url);

};

window.addEventListener('popstate', function(event) {

« no previous file with comments | « no previous file | ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js » ('j') | no next file with comments »