components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc - Issue 2249903003: 📰 Empty state handling for the Bookmarks section

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

Issue 2249903003: 📰 Empty state handling for the Bookmarks section (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/ntp_snippets/ntp_snippets_service.cc ('K') | « components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc ('k') | components/ntp_snippets_strings.grdp » ('j') | components/ntp_snippets_strings.grdp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

diff --git a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

index c77fd77ae28bb5a5d454e4c3c472d1ba93dfe85f..978deb7c5431ba1b2d20c6e0e9cbd237d67abfef 100644

--- a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

+++ b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

@@ -70,7 +70,8 @@ CategoryInfo PhysicalWebPageSuggestionsProvider::GetCategoryInfo(

// TODO(vitaliii): Use a proper string once it's been agreed on.

return CategoryInfo(base::ASCIIToUTF16("Physical web pages"),

ContentSuggestionsCardLayout::MINIMAL_CARD,

- /* has_more_button */ true);

+ /* has_more_button */ true,

+ /* show_if_empty */ false);

}

void PhysicalWebPageSuggestionsProvider::DismissSuggestion(