Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Unified Diff: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

Issue 2249903003: 📰 Empty state handling for the Bookmarks section (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
diff --git a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
index 7090d1281a185e1bfc740092db81d18213b1f331..8cec857617926aaf6e2bf2209e04fd0e2fbc112b 100644
--- a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
+++ b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
@@ -92,7 +92,9 @@ CategoryStatus BookmarkSuggestionsProvider::GetCategoryStatus(
CategoryInfo BookmarkSuggestionsProvider::GetCategoryInfo(Category category) {
return CategoryInfo(
l10n_util::GetStringUTF16(IDS_NTP_BOOKMARK_SUGGESTIONS_SECTION_HEADER),
- ContentSuggestionsCardLayout::MINIMAL_CARD, /* has_more_button */ true);
+ ContentSuggestionsCardLayout::MINIMAL_CARD,
+ /* has_more_button = */ true,
Bernhard Bauer 2016/08/17 20:38:03 Nit: I think the more common style is to leave the
dgn 2016/08/18 09:52:57 Done.
+ /* show_if_empty = */ false);
}
void BookmarkSuggestionsProvider::DismissSuggestion(

Powered by Google App Engine
This is Rietveld 408576698