components/ntp_snippets_strings.grdp - Issue 2249903003: 📰 Empty state handling for the Bookmarks section

Side by Side Diff: components/ntp_snippets_strings.grdp

Issue 2249903003: 📰 Empty state handling for the Bookmarks section (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <grit-part>	2 <grit-part>

3	3

4 <if expr="is_android">	4 <if expr="is_android">

5 <message name="IDS_SNIPPETS_DISABLED_SIGNED_OUT_INSTRUCTIONS" desc="Body of the card explaining the status of the content suggestions on the New Tab Page, w hen the user is signed out." formatter_data="android_java">	5 <message name="IDS_SNIPPETS_DISABLED_SIGNED_OUT_INSTRUCTIONS" desc="Body of the card explaining the status of the content suggestions on the New Tab Page, w hen the user is signed out." formatter_data="android_java">

6 To get personalized content suggested by Google, sign in to Chrome.	6 To get personalized content suggested by Google, sign in to Chrome.

7 </message>	7 </message>

8 <message name="IDS_SNIPPETS_DISABLED_GENERIC_PROMPT" desc="Title of the card explaining what action the user can take to get content suggestions on the New Tab Page." formatter_data="android_java">	8 <message name="IDS_SNIPPETS_DISABLED_GENERIC_PROMPT" desc="Title of the card explaining what action the user can take to get content suggestions on the New Tab Page." formatter_data="android_java">

9 Get suggested content	9 Get suggested content

10 </message>	10 </message>

	11 <message name="IDS_NTP_STATUS_CARD_DONE_FOR_NOW" desc="Title of the card exp laining to the user that they can expect to see bookmarks in this part of the Ne w Tab Page in the future." formatter_data="android_java">
	Bernhard Bauer 2016/08/17 20:38:03 Is the description correct here? Is the description correct here? dgn 2016/08/18 09:52:57 Changed the name of the string. I went with making Show quoted text On 2016/08/17 20:38:03, Bernhard Bauer wrote: > Is the description correct here? Changed the name of the string. I went with making the name and description have more info about the usage context, rather than being generic and closer to the value of the string. The wording gets changed every now and then so... New strings: https://goo.gl/photos/Dk9km48pv6dwPWv56
	12 Done for now

	13 </message>

	14 <message name="IDS_NTP_STATUS_CARD_NO_BOOKMARKS" desc="Text of the card expl aining to the user that they can expect to see bookmarks in this part of the New Tab Page in the future." formatter_data="android_java">

	15 Your recently visited bookmarks will show up here.

	16 </message>

11 </if>	17 </if>

12	18

13 <message name="IDS_NTP_ARTICLE_SUGGESTIONS_SECTION_HEADER" desc="Header of the articles section, which is a list of news articles displayed as cards on the Ne w Tab Page.">	19 <message name="IDS_NTP_ARTICLE_SUGGESTIONS_SECTION_HEADER" desc="Header of the articles section, which is a list of news articles displayed as cards on the Ne w Tab Page.">

14 Articles for you	20 Articles for you

15 </message>	21 </message>

16	22

17 <message name="IDS_NTP_RECENT_TAB_SUGGESTIONS_SECTION_HEADER" desc="Header of the recent tabs section, which is a list of pages that the user recently viewed, displayed as cards on the New Tab Page.">	23 <message name="IDS_NTP_RECENT_TAB_SUGGESTIONS_SECTION_HEADER" desc="Header of the recent tabs section, which is a list of pages that the user recently viewed, displayed as cards on the New Tab Page.">

18 Recent tabs	24 Recent tabs

19 </message>	25 </message>

20	26

21 <message name="IDS_NTP_DOWNLOAD_SUGGESTIONS_SECTION_HEADER" desc="Header of th e downloads section, which is a list of pages (or files) that the user downloade d, displayed as cards on the New Tab Page.">	27 <message name="IDS_NTP_DOWNLOAD_SUGGESTIONS_SECTION_HEADER" desc="Header of th e downloads section, which is a list of pages (or files) that the user downloade d, displayed as cards on the New Tab Page.">

22 Downloads	28 Downloads

23 </message>	29 </message>

24	30

25 <message name="IDS_NTP_BOOKMARK_SUGGESTIONS_SECTION_HEADER" desc="Header of th e bookmarks section, which is a list of the user's most recently used bookmarks displayed as cards on the New Tab Page.">	31 <message name="IDS_NTP_BOOKMARK_SUGGESTIONS_SECTION_HEADER" desc="Header of th e bookmarks section, which is a list of the user's most recently used bookmarks displayed as cards on the New Tab Page.">

26 Recent bookmarks	32 Recent bookmarks

27 </message>	33 </message>

28	34

29 </grit-part>	35 </grit-part>

OLD	NEW