Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2466)

Unified Diff: chrome/test/data/webui/settings/route_tests.js

Issue 2249873003: Settings: Fix Site Details subpage routing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix comment typo Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/route_tests.js
diff --git a/chrome/test/data/webui/settings/route_tests.js b/chrome/test/data/webui/settings/route_tests.js
index c84fbdc764b92eebf009b47dfef2923967e541af..0052d64e43ec2798112f66da20b70467e67dddd2 100644
--- a/chrome/test/data/webui/settings/route_tests.js
+++ b/chrome/test/data/webui/settings/route_tests.js
@@ -6,13 +6,16 @@ suite('route', function() {
test('tree structure', function() {
// Set up root page routes.
var BASIC = new settings.Route('/');
+ assertEquals(0, BASIC.depth);
+
var ADVANCED = new settings.Route('/advanced');
assertFalse(ADVANCED.isSubpage());
+ assertEquals(0, ADVANCED.depth);
// Test a section route.
- var PRIVACY = ADVANCED.createChild('/privacy');
- PRIVACY.section = 'privacy';
+ var PRIVACY = ADVANCED.createSection('/privacy', 'privacy');
assertEquals(ADVANCED, PRIVACY.parent);
+ assertEquals(1, PRIVACY.depth);
assertFalse(PRIVACY.isSubpage());
assertFalse(BASIC.contains(PRIVACY));
assertTrue(ADVANCED.contains(PRIVACY));
@@ -23,6 +26,7 @@ suite('route', function() {
var SITE_SETTINGS = PRIVACY.createChild('/siteSettings');
assertEquals('/siteSettings', SITE_SETTINGS.path);
assertEquals(PRIVACY, SITE_SETTINGS.parent);
+ assertEquals(2, SITE_SETTINGS.depth);
assertFalse(!!SITE_SETTINGS.dialog);
assertTrue(SITE_SETTINGS.isSubpage());
assertEquals('privacy', SITE_SETTINGS.section);
@@ -34,6 +38,7 @@ suite('route', function() {
var SITE_SETTINGS_ALL = SITE_SETTINGS.createChild('all');
assertEquals('/siteSettings/all', SITE_SETTINGS_ALL.path);
assertEquals(SITE_SETTINGS, SITE_SETTINGS_ALL.parent);
+ assertEquals(3, SITE_SETTINGS_ALL.depth);
assertTrue(SITE_SETTINGS_ALL.isSubpage());
});

Powered by Google App Engine
This is Rietveld 408576698